Skip to content

Add support for linux-arm64 using ubuntu-24.04-arm runner#23

Merged
d3m3vilurr merged 2 commits intovitasdk:masterfrom
joel16:linux-arm64
Mar 11, 2025
Merged

Add support for linux-arm64 using ubuntu-24.04-arm runner#23
d3m3vilurr merged 2 commits intovitasdk:masterfrom
joel16:linux-arm64

Conversation

@joel16
Copy link
Copy Markdown
Contributor

@joel16 joel16 commented Feb 8, 2025

  • Updates github workflows to use the arm64 runner for aarch64.
  • Update github actions:
    • Use actions/checkout@v4
    • Use actions/setup-python@v5
    • Use actions/upload-artifact@v4

I have also updated vdpm to check for linux arch (vitasdk/vdpm#107)

This needs to run first before the VDPM pull request can be accepted.

@joel16 joel16 marked this pull request as ready for review February 8, 2025 18:12
@joel16
Copy link
Copy Markdown
Contributor Author

joel16 commented Feb 15, 2025

@d3m3vilurr Did you get a chance to look at this? This should fix your concern with autobuilds and the VDPM pr lookup arch on linux before downloading from autobuilds.

@joel16
Copy link
Copy Markdown
Contributor Author

joel16 commented Mar 11, 2025

@d3m3vilurr Any update on this and vitasdk/vdpm#107?

@d3m3vilurr
Copy link
Copy Markdown
Contributor

sorry i'll re-review this at today night.
and thank you for your gentle ping.

@d3m3vilurr d3m3vilurr merged commit 0bf4308 into vitasdk:master Mar 11, 2025
@d3m3vilurr
Copy link
Copy Markdown
Contributor

d3m3vilurr commented Mar 11, 2025

@joel16 cannot build aarch64

Invalid configuration `aarch64-linux-gnu': machine `aarch64' not recognized
configure: error: /bin/bash /home/runner/work/autobuilds/autobuilds/buildscripts/build/libelf_build-prefix/src/libelf_build/config.sub aarch64-linux-gnu failed
make[3]: *** [CMakeFiles/libelf_build.dir/build.make:93: libelf_build-prefix/src/libelf_build-stamp/libelf_build-configure] Error 1
make[2]: *** [CMakeFiles/Makefile2:209: CMakeFiles/libelf_build.dir/all] Error 2

do you have any idea?? :'(


ah config.sub file of libelf needs extra patch to arch matching

@joel16 can you support this if you having arm64 linux??

@joel16
Copy link
Copy Markdown
Contributor Author

joel16 commented Mar 11, 2025

@joel16 cannot build aarch64

Invalid configuration `aarch64-linux-gnu': machine `aarch64' not recognized
configure: error: /bin/bash /home/runner/work/autobuilds/autobuilds/buildscripts/build/libelf_build-prefix/src/libelf_build/config.sub aarch64-linux-gnu failed
make[3]: *** [CMakeFiles/libelf_build.dir/build.make:93: libelf_build-prefix/src/libelf_build-stamp/libelf_build-configure] Error 1
make[2]: *** [CMakeFiles/Makefile2:209: CMakeFiles/libelf_build.dir/all] Error 2

do you have any idea?? :'(

ah config.sub file of libelf needs extra patch to arch matching

@joel16 can you support this if you having arm64 linux??

Strange.. The build was working without any patches when I last tested it. Here's the auto build from my branch: https://github.com/joel16/autobuilds/actions/runs/13215713668/job/36894737110

I'll have a look and see if I can reproduce and get back to you.

@d3m3vilurr
Copy link
Copy Markdown
Contributor

@joel16 cannot build aarch64

Invalid configuration `aarch64-linux-gnu': machine `aarch64' not recognized
configure: error: /bin/bash /home/runner/work/autobuilds/autobuilds/buildscripts/build/libelf_build-prefix/src/libelf_build/config.sub aarch64-linux-gnu failed
make[3]: *** [CMakeFiles/libelf_build.dir/build.make:93: libelf_build-prefix/src/libelf_build-stamp/libelf_build-configure] Error 1
make[2]: *** [CMakeFiles/Makefile2:209: CMakeFiles/libelf_build.dir/all] Error 2

do you have any idea?? :'(
ah config.sub file of libelf needs extra patch to arch matching
@joel16 can you support this if you having arm64 linux??

Strange.. The build was working without any patches when I last tested it. Here's the auto build from my branch: https://github.com/joel16/autobuilds/actions/runs/13215713668/job/36894737110

I'll have a look and see if I can reproduce and get back to you.

yeah. I also see it before merging.
but your recent testing ci is also broken with same reason.
https://github.com/joel16/autobuilds/actions/runs/13295048278/job/37126779961

our libelf is too old version, that doesn't define aarch64 arch in config.sub file.

just problem is, i'm sorry, i don't have arm64 linux machine for testing & fixing. :(

@joel16
Copy link
Copy Markdown
Contributor Author

joel16 commented Mar 12, 2025

@d3m3vilurr looks like there are already PRs for buildscipts to update libelf's config.sub to support aarch64:

@d3m3vilurr
Copy link
Copy Markdown
Contributor

@d3m3vilurr looks like there are already PRs for buildscipts to update libelf's config.sub to support aarch64:

* [Fix libelf autoconf for unsupported architectures  buildscripts#107](https://github.com/vitasdk/buildscripts/pull/107)

it contains multiple things to update. I'm not sure that we need all patch of them.
and also, /usr/share/misc/config.sub seems system dependent.
for example, archlinux doesn't have this.

* [Make it possible to compile with aarch64 buildscripts#122](https://github.com/vitasdk/buildscripts/pull/122)

I remember this PR, but it seems copy & paste config files from newer libelf.
so, I also don't know it's correct work or not. (so I ignored at that time..)

@SonicMastr said second patch would same as first patchset version.. but, imo if both are same and they also work as well, second one is better than first one.

@joel16
Copy link
Copy Markdown
Contributor Author

joel16 commented Mar 20, 2025

Then I'd say we should go for the second one, I believe that should fix the build here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants