Reproduction of using node_modules server components with client component inside of it#906
Draft
kasperpeulen wants to merge 1 commit intovitejs:mainfrom
Draft
Conversation
Contributor
|
This is likely because vite-plugin-react/packages/plugin-rsc/src/plugin.ts Lines 380 to 386 in 5e245aa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We export the following component in storybook:
Which can be used inside of server components of the user.
But somehow, if it is used in server components inside of node_modules it breaks.
For example, this is the content of
@storybook/nextjs-vite-rsc/reproThis breaks, and I get error messages that the NextRouter is being loaded on the server: