fix: resolve pnpm .modules.yaml from workspace root instead of cwd#22757
Open
btea wants to merge 2 commits into
Open
fix: resolve pnpm .modules.yaml from workspace root instead of cwd#22757btea wants to merge 2 commits into
btea wants to merge 2 commits into
Conversation
bluwy
reviewed
Jun 24, 2026
| const pnpmModulesYaml = path.join(cwd, 'node_modules', '.modules.yaml') | ||
| // Use workspace root (not package root) because .modules.yaml lives at the | ||
| // monorepo root's node_modules/, not in nested workspace packages. | ||
| const wsRoot = searchForWorkspaceRoot(root) |
Member
There was a problem hiding this comment.
Could we hoist this up to before the const server variable so that it can also reuse this value, and rename this as workspaceRoot? ws feels a bit like websockets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #22748