🐛 Fix comparisons command returning empty results#208
Conversation
…uild
getBuild() expects a string for the include param, but both commands were
passing { include: 'comparisons' } which serialized to [object Object] in
the query string — causing the API to return empty comparisons.
Vizzly - Visual Test ResultsCLI Reporter - 5 changes need review
Changes needing review (5)filter-failed-only · Firefox · 1920×1080 · 0.0% diff fullscreen-viewer · Firefox · 1920×1080 · 1.6% diff bulk-accept-dialog · Firefox · 1920×1080 · 10.4% diff viewer-zoomed-100 · Firefox · 1920×1080 · 0.4% diff fullscreen-viewer · Firefox · 375×667 · 161.3% diff
|
Review SummaryExcellent catch! This PR fixes a critical bug where the ✅ Strengths
Code Quality
RecommendationApprove and merge. This is a straightforward bug fix with proper test coverage. The PR follows the repository's conventions (gitmoji prefix, clear summary, test plan) per CLAUDE.md guidelines. |





Summary
getBuild()expects theincludeparameter as a string (e.g.'comparisons'), but bothcomparisons.jsandbuilds.jswere passing an object ({ include: 'comparisons' })include=[object Object], which the API didn't recognize — so comparisons were silently omitted from the responsegetBuildto prevent this regressionTest plan
npm testpasses (21 tests across both files, all green)vizzly comparisons --build <id>now returns comparison data instead of empty resultsvizzly builds --build <id> --comparisonsalso correctly includes comparisons