-
Notifications
You must be signed in to change notification settings - Fork 306
add kv quant example #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add kv quant example #2100
Conversation
Signed-off-by: Mengni Wang <mengni.wang@intel.com>
Summary of ChangesHello @mengniwang95, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Key-Value (KV) cache quantization into the existing AutoRound example, allowing users to optionally apply FP8 quantization to the KV cache. This enhancement provides a mechanism to explore the impact of KV cache quantization on model performance and resource utilization, with updated documentation to guide users through the process and present comparative accuracy metrics. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an example for KV cache quantization with AutoRound. The changes include updating the llama3_example.py script to support a --fp8_kv flag and modifying the corresponding README.md to document this new feature, including usage instructions and evaluation results. My review focuses on improving the clarity and correctness of the documentation in the README.md file. I've pointed out a confusing comment, a typo, and an incorrect markdown code block specifier. The code changes in the Python script look good and are clear for an example.
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Wang, Mengni <mengni.wang@intel.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Wang, Mengni <mengni.wang@intel.com>
Signed-off-by: Wang, Mengni <mengni.wang@intel.com>
|
@dsikka @kylesayrs @brian-dellabetta please help review the PR. Thanks. |
SUMMARY:
Add kv cache quantization into autoround example
TEST PLAN:
Have test the example offline