Remove a branch with pl.when in fetching bkv #1239
Open
+20
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rupengliu-meta <rupengliu@meta.com>
rupengliu-meta
requested review from
bythew3i,
kyuyeunk and
yaochengji
as code owners
vanbasten23
reviewed
Dec 4, 2025
| sem, | ||
| wait, | ||
| ) | ||
| size = lax.select(bkv_sz_frm_new > 0, bkv_sz_frm_new, 0) |
Collaborator
There was a problem hiding this comment.
so if size==0, then the dma will be a no-op?
vanbasten23
approved these changes
Dec 5, 2025
Collaborator
|
Also, can you do a rebase instead of merge to update the branch? There's a weird bug where pre merge ci doesn't run if you do merge. |
bythew3i
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussed with @bythew3i offline! This commit removes one control flow branch in path of prefetching bkv. Around 3% kernel speedup before tuning! (since I don't have tuning script, so unable to report updated speedup)
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
Tests
E2E tests
Integration tests:
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure: