Skip to content

fix: increase agent execute and chat completions timeouts to ≥600s#194

Merged
dineshreddy91 merged 2 commits into
mainfrom
devin/1780956983-increase-agent-timeouts
Jun 8, 2026
Merged

fix: increase agent execute and chat completions timeouts to ≥600s#194
dineshreddy91 merged 2 commits into
mainfrom
devin/1780956983-increase-agent-timeouts

Conversation

@dineshreddy91

@dineshreddy91 dineshreddy91 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Increase timeouts for Orion agent execute and chat completions to ≥600s to prevent premature errors and retries on long-running tasks.

Changes:

Location Before After
Agent.completions / Agent.async_completions OpenAI client self._client.timeout (120s default) max(self._client.timeout, 600)
Executions.__init__ APIRequestor 120s 600s
Executions.wait() default 300s 600s
Predictions.wait() default 300s 600s

The Agent.completions change uses max() so users who explicitly set a timeout >600s keep their value, while the default 120s gets bumped to 600s.

Related PRs: vlm-run/vlmrun-node-sdk (same changes), vlm-run/vlm-lab (server-side timeouts).

Link to Devin session: https://app.devin.ai/sessions/977e2c561b8c4ef8b72d04517946a4dc
Requested by: @dineshreddy91


Open in Devin Review

- Agent completions/async_completions: enforce min 600s timeout for OpenAI client
- Executions: increase HTTP request timeout from 120s to 600s
- Executions.wait: increase default polling timeout from 300s to 600s
- Predictions.wait: increase default polling timeout from 300s to 600s

Orion agent executions and chat completions can take several minutes,
especially for complex tasks. Previous timeouts (120-300s) caused
premature errors and retries.

Co-Authored-By: dinesh@vlm.run <dinesh.andromeda@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases various timeout values to 600 seconds across the agent, executions, and predictions clients. Feedback on these changes highlights a potential TypeError in agent.py if the client timeout is configured as None, and suggests safely handling this case. Additionally, increasing the APIRequestor timeout to 600 seconds in executions.py is discouraged, as it affects metadata operations that should fail quickly, whereas the long-running wait is already properly handled by the wait method's timeout.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread vlmrun/client/agent.py Outdated
Comment thread vlmrun/client/agent.py Outdated
Comment thread vlmrun/client/executions.py Outdated

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dineshreddy91 dineshreddy91 merged commit 6aebd37 into main Jun 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant