fix: make built ESM entrypoint importable#2
Open
slegarraga wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.jsextensions to local relative source imports/exports so the built ESM files are directly importable by Node../dist/index.jsafternpm run build.Why
The package is published with
"type": "module", but the current build emits extensionless relative imports such as./providerindist/index.js. Node's ESM loader does not resolve those specifiers, so importing the built package entrypoint fails withERR_MODULE_NOT_FOUNDafter a clean build.The new CI check catches that failure mode before publishing:
node --input-type=module -e "await import('./dist/index.js')"Validation
Local results:
npm test: 3 files passed, 101 tests passed.npm run build: completed successfully.entrypoint import ok.npm pack --dry-run: tarball includesdist/index.js.