Skip to content

fix: build per-version Vite stats through the vite-plus toolchain #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Jun 7, 2026
Merged

fix: build per-version Vite stats through the vite-plus toolchain #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 75 additions & 60 deletions tools/override-vite.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ import { existsSync, readdirSync, readFileSync, statSync, writeFileSync } from "
import https from "node:https";
import { join } from "node:path";

const DASHBOARD_PACKAGE_PATH = join(process.cwd(), "apps/dashboard/package.json");
const DIST_PATH = join(process.cwd(), "apps/dashboard/dist");
const DASHBOARD_DIR = join(process.cwd(), "apps/dashboard");
const WORKSPACE_PATH = join(process.cwd(), "pnpm-workspace.yaml");
const DIST_PATH = join(DASHBOARD_DIR, "dist");
const STATS_OUTPUT_PATH = join(process.cwd(), "data/vite-version-stats.json");

/**
Expand Down Expand Up @@ -87,56 +88,64 @@ async function fetchNpmPublicationDates() {
});
}

// Matches the `vite:` entry inside the top-level `overrides:` block of
// pnpm-workspace.yaml (the quoted form is unique to overrides; the catalog
// entry uses an unquoted `npm:` alias).
const OVERRIDE_VITE_RE = /^(overrides:\n(?:.*\n)*?[ \t]+vite: )"[^"]*"/m;

/**
* Get the current Vite version from package.json
* @returns {string} Current version string
* Get the current overridden Vite version from pnpm-workspace.yaml
* @returns {string} Current override value (e.g. "catalog:" or "8.0.0")
*/
function getCurrentVersion() {
try {
const packageJson = JSON.parse(readFileSync(DASHBOARD_PACKAGE_PATH, "utf8"));
return packageJson.devDependencies["vite"];
const workspace = readFileSync(WORKSPACE_PATH, "utf8");
const match = workspace.match(OVERRIDE_VITE_RE);
return match ? match[0].split('"')[1] : "";
} catch (error) {
console.error("Error reading package.json:", error.message);
console.error("Error reading pnpm-workspace.yaml:", error.message);
process.exit(1);
// Unreachable return to satisfy consistent-return linter rule
return "";
}
}

/**
* Update the Vite version in package.json
* @param {string} version - Target version to update to
* Pin the Vite version via the pnpm `overrides` entry in pnpm-workspace.yaml.
* Vite+ resolves the `vite` dependency through this override, so this is the
* supported way to build the dashboard against a specific Vite release.
* @param {string} version - Target version to pin (e.g. "8.0.0")
* @returns {boolean} Success status
*/
function updateViteVersion(version) {
try {
console.log(`📦 Updating vite to version: ${version}`);

// Read current package.json
const packageJson = JSON.parse(readFileSync(DASHBOARD_PACKAGE_PATH, "utf8"));
console.log(`📦 Overriding vite to version: ${version}`);

// Update vite version
packageJson.devDependencies["vite"] = version;
const workspace = readFileSync(WORKSPACE_PATH, "utf8");
if (!OVERRIDE_VITE_RE.test(workspace)) {
console.error("❌ Could not find a `vite` entry under `overrides:` in pnpm-workspace.yaml");
return false;
}

// Write back to package.json
writeFileSync(DASHBOARD_PACKAGE_PATH, JSON.stringify(packageJson, null, 2) + "\n");
const updated = workspace.replace(OVERRIDE_VITE_RE, `$1"${version}"`);
writeFileSync(WORKSPACE_PATH, updated);

console.log("✅ Package.json updated successfully");
console.log("✅ pnpm-workspace.yaml override updated successfully");
return true;
} catch (error) {
console.error("❌ Error updating package.json:", error.message);
console.error("❌ Error updating pnpm-workspace.yaml:", error.message);
return false;
}
}

/**
* Install dependencies using pnpm
* Install dependencies using Vite+
* @returns {boolean} Success status
*/
function installDependencies() {
try {
console.log("📥 Installing dependencies...");
execSync("pnpm install --no-frozen-lockfile", {
execSync("vp install --no-frozen-lockfile", {
stdio: "inherit",
cwd: process.cwd(),
env: process.env,
Expand All @@ -145,24 +154,24 @@ function installDependencies() {
return true;
} catch (error) {
console.error("❌ Error installing dependencies:", error.message);
console.error("❌ Aborting due to pnpm install failure");
console.error("❌ Aborting due to install failure");
process.exit(1);
// Unreachable return to satisfy consistent-return linter rule
return false;
}
}

/**
* Build the application using Vite
* Build the application using Vite+
* @returns {{ success: boolean, buildTime: number | null }} Build result with timing
*/
function buildApp() {
try {
console.log("🔨 Building application...");
const startTime = Date.now();
execSync("./node_modules/vite/bin/vite.js build", {
execSync("vp build", {
stdio: "inherit",
cwd: join(process.cwd(), "apps/dashboard"),
cwd: DASHBOARD_DIR,
});
const buildTime = Date.now() - startTime;
console.log(`✅ Build completed successfully in ${buildTime}ms`);
Expand All @@ -173,6 +182,40 @@ function buildApp() {
}
}

/**
* Recursively list files under a directory with their sizes and types
* @param {string} dir - Directory to walk
* @param {string} baseDir - Relative path prefix for collected entries
* @returns {Array<{ path: string, size: number, type: string }>} File entries
*/
function getFilesRecursively(dir, baseDir = "") {
const files = [];
const items = readdirSync(dir);

for (const item of items) {
const fullPath = join(dir, item);
const relativePath = join(baseDir, item);
const stat = statSync(fullPath);

if (stat.isDirectory()) {
files.push(...getFilesRecursively(fullPath, relativePath));
} else {
files.push({
path: relativePath,
size: stat.size,
type: item.endsWith(".js")
? "js"
: item.endsWith(".css")
? "css"
: item.endsWith(".html")
? "html"
: "other",
});
}
}
return files;
}

/**
* Collect file statistics from the dist directory
* @param {string} version - Vite version
Expand All @@ -196,35 +239,6 @@ function collectDistStats(version, buildTime = null, publicationDate = null) {
}

try {
// Get all files recursively
function getFilesRecursively(dir, baseDir = "") {
const files = [];
const items = readdirSync(dir);

for (const item of items) {
const fullPath = join(dir, item);
const relativePath = join(baseDir, item);
const stat = statSync(fullPath);

if (stat.isDirectory()) {
files.push(...getFilesRecursively(fullPath, relativePath));
} else {
files.push({
path: relativePath,
size: stat.size,
type: item.endsWith(".js")
? "js"
: item.endsWith(".css")
? "css"
: item.endsWith(".html")
? "html"
: "other",
});
}
}
return files;
}

stats.files = getFilesRecursively(DIST_PATH);
stats.totalSize = stats.files.reduce((total, file) => total + file.size, 0);

Expand Down Expand Up @@ -293,8 +307,8 @@ async function collectAllVersionStats() {

console.log(`📦 Found ${stableVersions.length} versions to analyze`);

// Store original package.json for restoration
const originalPackageJson = readFileSync(DASHBOARD_PACKAGE_PATH, "utf8");
// Store original pnpm-workspace.yaml for restoration
const originalWorkspace = readFileSync(WORKSPACE_PATH, "utf8");

for (let i = 0; i < stableVersions.length; i++) {
const version = stableVersions[i];
Expand All @@ -308,7 +322,7 @@ async function collectAllVersionStats() {
try {
// Update version
if (!updateViteVersion(version)) {
console.error(`❌ Failed to update package.json for version ${version}`);
console.error(`❌ Failed to override vite version ${version}`);
failureCount++;
continue;
}
Expand Down Expand Up @@ -341,9 +355,10 @@ async function collectAllVersionStats() {
}
}

// Restore original package.json
console.log("\n🔄 Restoring original package.json...");
writeFileSync(DASHBOARD_PACKAGE_PATH, originalPackageJson);
// Restore original pnpm-workspace.yaml and reinstall to reset the lockfile
console.log("\n🔄 Restoring original pnpm-workspace.yaml...");
writeFileSync(WORKSPACE_PATH, originalWorkspace);
installDependencies();

// Save results. Skip writing an empty dataset (e.g. when no stable Vite 8
// release exists yet) so we don't clobber the existing tracked stats and
Expand Down
Loading