refactor(vite_install): centralize Yarn v1/berry branching with is_yarn_berry#1897
Merged
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
Managing Yarn seems pretty complicated🥲 |
Member
|
@jong-kyung Each new package manager doubles the maintenance complexity. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor Yarn version branching in
vite_installcommand handlers to use the shared helperself.is_yarn_berry()instead of direct version string checks (self.version.starts_with("1.")/is_yarn_v1).Why
Yarn version branching logic (
v1vsberry) was duplicated across many commands.This change centralizes the check via
is_yarn_berry()for better readability and consistency, while keeping behavior unchanged.What changed
Replaced direct Yarn v1 checks with
let is_berry = self.is_yarn_berry();