fix(upgrade): run pinned pnpm with managed Node#1900
Merged
fengmk2 merged 5 commits intoJun 21, 2026
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23694a1943
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
liangmiQwQ
changed the title
liangmiQwQ
force-pushed
the
liang/codex/fix-upgrade-node-runtime
branch
from
6a5dec9 to
d4dc75b
Compare
fengmk2
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1876
The dependency install spawned by
vp upgradecurrently re-entersvp install, which can select a session, project, or system-first Node.js runtime. An incompatible runtime can make pnpm skip optional native binaries and leave the upgraded CLI broken.This PR removes that recursive path. The setup flow resolves and downloads the latest managed Node.js LTS runtime, downloads the pinned pnpm version, and runs
node pnpm.cjs installdirectly. This bypassesVP_NODE_VERSION,.session-node-version, project runtime configuration, andvp env offwhile keeping the install script and upgrade flow on the same managed bootstrap path.🤖 Generated with Codex