Skip to content

fix(migration): link git hook warning to migration guide #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 4 commits into from
Jun 22, 2026
+2 −2
Merged

fix(migration): link git hook warning to migration guide #1902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91e28f7
docs(migrator): update git hooks setup message to include migration g…
naokihaba Jun 21, 2026
49e7d9f
docs(migration): update message to include link for manual git hooks …
naokihaba Jun 21, 2026
1aa166f
Merge branch 'main' into main
naokihaba Jun 21, 2026
a464af0
Merge branch 'main' into main
fengmk2 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/snap-tests-global/migration-other-hook-tool/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
> vp migrate --no-interactive # hooks should be skipped due to simple-git-hooks

⚠ Detected simple-git-hooks — skipping git hooks setup. Please configure git hooks manually.
⚠ Detected simple-git-hooks — skipping git hooks setup. Please configure git hooks manually, see https://viteplus.dev/guide/migrate#git-hook-tools
◇ Migrated . to Vite+
• Node <semver> pnpm <semver>
• 1 config update applied
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/migration/migrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5080,7 +5080,7 @@ export function preflightGitHooksSetup(
const prodDeps = pkgContent.dependencies as Record<string, string> | undefined;
for (const tool of OTHER_HOOK_TOOLS) {
if (deps?.[tool] || prodDeps?.[tool] || pkgContent[tool]) {
return `Detected ${tool} — skipping git hooks setup. Please configure git hooks manually.`;
return `Detected ${tool} — skipping git hooks setup. Please configure git hooks manually, see https://viteplus.dev/guide/migrate#git-hook-tools`;
}
}
const huskyReason = checkUnsupportedHuskyVersion(projectPath, deps, prodDeps, packageManager);
Expand Down
Loading