feat: passthrough fallback for vpr/vp i on low Node (#1909 #1916)#1921
Open
l246804 wants to merge 1 commit into
Open
feat: passthrough fallback for vpr/vp i on low Node (#1909 #1916)#1921l246804 wants to merge 1 commit into
l246804 wants to merge 1 commit into
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
liangmiQwQ
reviewed
Jun 23, 2026
Collaborator
There was a problem hiding this comment.
Thanks!
plans/2026-06-23-low-node-passthrough.md and specs/2026-06-23-low-node-passthrough-design.md seem left by mistake?
Could you please also clean up outdated comments and dead code like Wired in Task X?
Collaborator
|
I tested locally, and I found it only works for |
|
To use Codex here, create an environment for this repo. |
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d290e8af8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
l246804
pushed a commit
to l246804/vite-plus
that referenced
this pull request
Jun 24, 2026
The vpr shim goes through shim::dispatch → commands::vpr::execute_vpr → delegate::execute, which bypasses run_command_with_options where the passthrough precheck lives. This meant vpr on low-Node projects still crashed with the styleText ESM error. Add the same passthrough precheck logic to execute_vpr: resolve the project's Node version, check should_passthrough, and if eligible call passthrough::execute before delegating to the JS CLI. Fixes the issue reported in PR voidzero-dev#1921 review where vpr didn't work with passthrough. Verified: RUSTC_BOOTSTRAP=1 cargo test -p vite_global_cli --bin vp passthrough -> 6 passed.
Closes voidzero-dev#1909 Closes voidzero-dev#1916 When the project's resolved Node version is below the supported minimum (20.19.0), eligible commands (vp run/vpr + package-manager family) bypass the Vite+ JS CLI and run the project's package manager directly. - Add shared passthrough module (vite_shared) with version comparison - Add passthrough command routing (vite_global_cli) with PATH handling - Add dispatch_with_pm for externally-provided PackageManager - Add detect_only on PackageManagerBuilder (no devEngines pin) - Defer is_low_node check in vpx until actually needed - Use vite_shared path utilities for safe non-UTF-8 PATH handling
l246804
force-pushed
the
feat/low-node-passthrough
branch
from
5cfcafa to
3a95df9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vpr/vp runand the package-manager family bypass the Vite+ JS CLI and run the project's own package manager directly.styleTextcrash on Node < 20.12 — never loads Vite+ JS) and the low-Node case of bug: vp i pins npm@11 into devEngines on low Node, breaking manual npm with "Cannot find module node:path" #1916 (no longer pins/downloads an incompatible npm, no longer writesdevEngines).devEngines"fail leaves side effects" general fix (deferred pin) is split into a follow-up PR.Closes #1909 (low-Node passthrough). Refs #1916.
Changes
vite_sharedMIN_SUPPORTED_NODE = "20.19.0"constant +is_node_below_min()helpervite_installPackageManagerBuilder::detect_only()— builds PM without writing devEnginesvite_pm_clidispatch_with_pm()+ 12*_with_pmhandler variants for external PM injectionvite_global_cliis_eligible,should_passthrough,execute) + precheck inrun_command_with_optionsHow it works
run_command_with_options, before the command match, check if the command is eligible (Run / PackageManager) and the project's resolved Node < 20.19.0.detect_only(no devEngines pin), and dispatch viadispatch_with_pm(PM commands) orrun_command(Run commands).Test plan
cargo test -p vite_shared --lib→ 92 passedcargo test -p vite_install --lib→ 552 passedcargo test -p vite_pm_cli --lib→ 12 passedcargo test -p vite_global_cli --bin vp passthrough→ 6 passedcargo clippyon all 4 crates → clean.node-version=14.15.0+vpr/vp ipassthrough, nodevEngineswrittenpnpm bootstrap-cli && pnpm test && git status(requires cmake)