Skip to content

fix(pm): allow cache flags without separator #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jong-kyung wants to merge 4 commits into from
+15 −4
Closed

fix(pm): allow cache flags without separator #1931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b189c36
fix(pm): allow cache flags without separator
jong-kyung Jun 24, 2026
83f866f
test(pm): remove npm cache clean snap
jong-kyung Jun 24, 2026
e04850e
test(pm): remove cache clean snap commands
jong-kyung Jun 24, 2026
c4c1f35
Merge branch 'main' into fix/pm-cache-pass-through-flags
jong-kyung Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion crates/vite_pm_cli/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ pub enum PmCommands {
subcommand: String,

/// Additional arguments
#[arg(last = true, allow_hyphen_values = true)]
#[arg(allow_hyphen_values = true, trailing_var_arg = true)]
pass_through_args: Option<Vec<String>>,
},

Expand Down Expand Up @@ -1416,6 +1416,17 @@ mod tests {
assert_eq!(pass_through_args, Some(vec!["--workspace-root".to_string()]));
}

#[test]
fn cache_clean_accepts_flags_without_separator() {
let command = parse_pm_command(&["vp", "pm", "cache", "clean", "--force"])
.expect("cache pass-through flags should parse");

let PackageManagerCommand::Pm(PmCommands::Cache { pass_through_args, .. }) = command else {
panic!("expected Cache variant");
};
assert_eq!(pass_through_args, Some(vec!["--force".to_string()]));
}

#[test]
fn stage_publish_parses() {
let command = parse_pm_command(&["vp", "pm", "stage", "publish", "--tag", "next"])
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/snap-tests-global/command-cache-bun/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
> vp pm cache --help # should show help
Usage: vp pm cache <SUBCOMMAND> [-- <PASS_THROUGH_ARGS>...]
Usage: vp pm cache <SUBCOMMAND> [PASS_THROUGH_ARGS]...

Manage package cache

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/snap-tests-global/command-cache-pnpm10/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
> vp pm cache --help # should show help
Usage: vp pm cache <SUBCOMMAND> [-- <PASS_THROUGH_ARGS>...]
Usage: vp pm cache <SUBCOMMAND> [PASS_THROUGH_ARGS]...

Manage package cache

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/snap-tests-global/command-cache-pnpm11/snap.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
> vp pm cache --help # should show help
Usage: vp pm cache <SUBCOMMAND> [-- <PASS_THROUGH_ARGS>...]
Usage: vp pm cache <SUBCOMMAND> [PASS_THROUGH_ARGS]...

Manage package cache

Expand Down
Loading