fix(env): preserve managed npm in node child processes#1938
Merged
fengmk2 merged 10 commits intoJun 25, 2026
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
added
test: e2e
fengmk2
reviewed
Jun 25, 2026
fengmk2
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1935, similar to #1654
The current node shim prepends the managed Node.js bin directory to PATH for child processes. That keeps
noderesolution stable, but it also lets the Node-bundlednpmandnpxshadow a project-declared managed npm version.This PR keeps the Node runtime bin on PATH, and when the current project declares npm through
packageManagerordevEngines.packageManager, it also prepends the resolved managed npm bin directory ahead of the Node runtime bin. It means child processes spawned fromnodeuse the same npm version that Vite+ resolves for the project.🤖 Generated with Codex.