fix(cli): skip lazyPlugins only while resolving config metadata by fengmk2 · Pull Request #1939 · voidzero-dev/vite-plus

fengmk2 · 2026-06-24T14:24:17Z

Problem

lazyPlugins decided whether to run the user's plugin factory from VP_COMMAND. That signal is:

overloaded — vp run's task-discovery config read and a verbatim build child both see run;
unnormalized — the vp format alias is format, not fmt;
inherited by spawned children.

So a Vite build spawned under vp run (a verbatim node build.mjs task) or vp exec built without the user's plugins, while vp format wrongly loaded them. (Both were raised in review.)

Fix

Decide from the resolution intent instead of the command name. The metadata resolvers (resolveViteConfig, migrate's rolldown-compat check, and the oxlint/oxfmt subprocess) mark that the config is being loaded only to read a config block, and lazyPlugins skips the factory only while that marker is set.

The default is to load, so dev/build/test/preview and any spawned build keep their plugins, regardless of which command launched them. The marker is scoped to the resolution, so it never leaks to task children, and it's immune to aliases and not-yet-known commands.

VP_COMMAND had no other reader, so it's removed.

Adds snap tests for the two fixed cases (verbatim vp run build loads plugins; vp format skips them) plus updated unit tests and docs.

netlify · 2026-06-24T14:24:23Z

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	`4fe8e85`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/6a3c8892422e810008dad80c
😎 Deploy Preview	https://deploy-preview-1939--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-06-24T14:26:08Z

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: 4fe8e85

fengmk2 · 2026-06-24T16:21:17Z

@codex review

lazyPlugins decided whether to run the user's plugin factory from VP_COMMAND. That signal is overloaded (the `vp run` task-discovery read and a verbatim build child both see `run`), unnormalized (the `vp format` alias is `format`, not `fmt`), and inherited by spawned children. As a result a Vite build spawned under `vp run` (a verbatim `node build.mjs` task) or `vp exec` built without the user's plugins, while `vp format` wrongly loaded them. Decide from the resolution intent instead: the metadata resolvers (resolveViteConfig, migrate's rolldown-compat check, and the oxlint/oxfmt subprocess) mark that the config is being loaded only to read a config block, and lazyPlugins skips the factory only while that marker is set. The default is to load, so dev/build/test/preview and any spawned build keep their plugins. VP_COMMAND had no other reader, so it is removed.

fengmk2 · 2026-06-25T00:31:48Z

@codex review

chatgpt-codex-connector · 2026-06-25T00:38:53Z

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: ec0a6ddf0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 self-assigned this Jun 24, 2026

fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels Jun 24, 2026

fengmk2 force-pushed the fix-lazyplugins-blacklist branch from 1319bd1 to aca3722 Compare June 24, 2026 14:43