Skip to content

refactor(fspy): own macOS shared-memory mapping#526

Merged
wan9chi merged 18 commits into
mainfrom
macos-shm-backend
Jul 11, 2026
Merged

refactor(fspy): own macOS shared-memory mapping#526
wan9chi merged 18 commits into
mainfrom
macos-shm-backend

Conversation

@wan9chi

@wan9chi wan9chi commented Jul 9, 2026

Copy link
Copy Markdown
Member

Motivation

Replace the last shared_memory backend and remove the dependency from the workspace.

Changes

  • Implements macOS shared memory with POSIX shm_open and memmap2.
  • Uses the full POSIX object name as the identifier passed to open.
  • Derives the mapping length from the opened POSIX object.
  • Generates names from URL-safe UUIDs and retries name collisions.
  • Unlinks the name when the owner is dropped or creation fails.
  • Keeps existing views valid after unlink while rejecting later opens.
  • Removes shared_memory and its unused transitive dependencies.

wan9chi commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@wan9chi wan9chi force-pushed the windows-sparse-shm branch from 2ee5a9c to a7e9506 Compare July 9, 2026 05:13
@wan9chi wan9chi force-pushed the macos-shm-backend branch 2 times, most recently from 53d767e to fe06fe8 Compare July 9, 2026 05:23
@wan9chi wan9chi force-pushed the windows-sparse-shm branch from a7e9506 to 41e4c55 Compare July 9, 2026 05:23
@wan9chi wan9chi force-pushed the macos-shm-backend branch from fe06fe8 to dfa0cde Compare July 9, 2026 05:29
@wan9chi wan9chi force-pushed the windows-sparse-shm branch 2 times, most recently from 4190b5e to b38ebb3 Compare July 9, 2026 05:36
@wan9chi wan9chi force-pushed the macos-shm-backend branch from dfa0cde to c681ad5 Compare July 9, 2026 05:36
@wan9chi wan9chi marked this pull request as ready for review July 9, 2026 05:42
@wan9chi wan9chi force-pushed the windows-sparse-shm branch from b38ebb3 to daf99c3 Compare July 9, 2026 07:58
@wan9chi wan9chi force-pushed the macos-shm-backend branch from c681ad5 to 3b57093 Compare July 9, 2026 07:58
@wan9chi wan9chi force-pushed the windows-sparse-shm branch from daf99c3 to a9b45dc Compare July 9, 2026 14:17
@wan9chi wan9chi force-pushed the macos-shm-backend branch from 3b57093 to e37f423 Compare July 9, 2026 14:18
@wan9chi wan9chi marked this pull request as draft July 10, 2026 01:16
@wan9chi wan9chi force-pushed the windows-sparse-shm branch from a9b45dc to 0de39b7 Compare July 10, 2026 06:03
@wan9chi wan9chi force-pushed the macos-shm-backend branch from e37f423 to 95914e5 Compare July 10, 2026 06:03
@wan9chi wan9chi force-pushed the windows-sparse-shm branch from 0de39b7 to 6df5e61 Compare July 10, 2026 06:57
@wan9chi wan9chi force-pushed the macos-shm-backend branch 2 times, most recently from 502b269 to e3b0be7 Compare July 10, 2026 07:04
@wan9chi wan9chi force-pushed the windows-sparse-shm branch 2 times, most recently from 91edb14 to fd848aa Compare July 10, 2026 07:14
@wan9chi wan9chi force-pushed the macos-shm-backend branch from e3b0be7 to e7f900f Compare July 10, 2026 07:14
@wan9chi wan9chi force-pushed the windows-sparse-shm branch from fd848aa to c21af71 Compare July 10, 2026 07:27
@wan9chi wan9chi force-pushed the macos-shm-backend branch from 313a952 to 9506028 Compare July 11, 2026 00:38
@wan9chi wan9chi marked this pull request as ready for review July 11, 2026 00:44
@wan9chi wan9chi force-pushed the windows-shm-backend branch 2 times, most recently from d9c88f3 to e476b9c Compare July 11, 2026 00:45
@wan9chi wan9chi changed the base branch from windows-shm-backend to graphite-base/526 July 11, 2026 00:48
wan9chi and others added 17 commits July 11, 2026 00:49
Co-authored-by: GPT-5.6 <gpt-5.6@openai.com>

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi wan9chi force-pushed the macos-shm-backend branch from 9506028 to 9b5d7a2 Compare July 11, 2026 00:49
@wan9chi wan9chi force-pushed the graphite-base/526 branch from f2337e4 to 17fe597 Compare July 11, 2026 00:49
@graphite-app graphite-app Bot changed the base branch from graphite-base/526 to main July 11, 2026 00:49
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi wan9chi force-pushed the macos-shm-backend branch from 9b5d7a2 to d4719a8 Compare July 11, 2026 00:49
@wan9chi wan9chi merged commit 049f3f0 into main Jul 11, 2026
16 checks passed

wan9chi commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

Merge activity

@wan9chi wan9chi deleted the macos-shm-backend branch July 11, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant