Skip to content

PREPARE DCO-SIGNOFF precommit message#137

Open
RONAK-AI647 wants to merge 1 commit intovolcano-sh:mainfrom
RONAK-AI647:RONAK-A1647/Ensure-DCO-checks-don't-fail-and-precommit-reminds-that-the-commit-is-not-signed-off
Open

PREPARE DCO-SIGNOFF precommit message#137
RONAK-AI647 wants to merge 1 commit intovolcano-sh:mainfrom
RONAK-AI647:RONAK-A1647/Ensure-DCO-checks-don't-fail-and-precommit-reminds-that-the-commit-is-not-signed-off

Conversation

@RONAK-AI647
Copy link
Copy Markdown

@RONAK-AI647 RONAK-AI647 commented May 22, 2025

The pre commit will remind them that their commits are not signed off , like this the initial failing off the DCO check and then another commit to rebase and force-push the branch will be avoided,
Fixes #127

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: RONAK <codeitronak226277@gmail.com>
@RONAK-AI647 RONAK-AI647 force-pushed the RONAK-A1647/Ensure-DCO-checks-don't-fail-and-precommit-reminds-that-the-commit-is-not-signed-off branch from 06a1668 to 0584284 Compare May 22, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a DCO pre-commit check using Husky

2 participants