Skip to content

perf: avoid eager canonicalize in StructReader #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a10y wants to merge 1 commit into
base: develop
Choose a base branch
from

perf: avoid eager canonicalize in StructReader

65443f7
Select commit
Loading
Failed to load commit list.
Open

perf: avoid eager canonicalize in StructReader #5721

perf: avoid eager canonicalize in StructReader
65443f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2025 in 0s

18.32% (-64.63%) compared to 7738f09

View this Pull Request on Codecov

18.32% (-64.63%) compared to 7738f09

Details

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.32%. Comparing base (7738f09) to head (65443f7).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-layout/src/layouts/struct_/reader.rs 0.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7738f09) and HEAD (65443f7). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (7738f09) HEAD (65443f7)
tests 1 0
tpc-h 1 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov