Fuzzing Crash: VortexError in file_io#8017
Open
vortex-claude[bot] wants to merge 1 commit into
Open
Conversation
When a bound scalar's storage type is wider than the array's storage type
(e.g. DecimalValue::I32(82246) vs an I16-backed array), the previous code
called vortex_bail!, which caused a panic in the fuzzer harness.
The new approach casts the bound to the array's storage type T and, when
the cast fails, determines the answer directly from the overflow direction:
• non-negative value that doesn't fit in T → value > T::MAX
– lower bound: no array value satisfies lower ≤ value → all-false
– upper bound: all array values satisfy value ≤ upper → no constraint
• negative value that doesn't fit in T → value < T::MIN
– lower bound: all array values satisfy lower ≤ value → no constraint
– upper bound: no array value satisfies value ≤ upper → all-false
This works for both strict and non-strict comparisons because the overflow
is by at least one integer, so no boundary element can change the outcome.
Also adds `DecimalValue::as_i256()` as a public utility method and
updates `public-api.lock` accordingly.
Fixes #7955
Co-authored-by: Joe Isaacs <joseph-isaacs@users.noreply.github.com>
Signed-off-by: "Claude" <claude@anthropic.com>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.3 µs | 307.9 µs | -11.26% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
224.8 µs | 187.9 µs | +19.65% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/issue-7955-20260519-0959 (3845a83) with develop (5330f74)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7955
Generated with Claude Code.
View Claude run