Skip to content

Skip computation of expression return dtype unless there are no chunks to return#8045

Open
robert3005 wants to merge 1 commit into
developfrom
rk/chunkedreader
Open

Skip computation of expression return dtype unless there are no chunks to return#8045
robert3005 wants to merge 1 commit into
developfrom
rk/chunkedreader

Conversation

@robert3005
Copy link
Copy Markdown
Contributor

This would only ever catch implementation bugs and we explicitly handle empty
chunks case

to return

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label May 21, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 21, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1235 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.9 µs 197.7 µs -18.08%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 224.8 µs 187.5 µs +19.85%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/chunkedreader (fc2f879) with develop (06cf4a3)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant