Skip to content

Conversation

@kluge7
Copy link
Contributor

@kluge7 kluge7 commented Feb 24, 2025

Add CI/CD pipeline for Industrial CI and Code coverage. Also add status badges.

@kluge7 kluge7 requested a review from Andeshog February 24, 2025 19:46
@kluge7 kluge7 self-assigned this Feb 24, 2025
@codecov
Copy link

codecov bot commented Feb 24, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@kluge7 kluge7 requested a review from Hallfred February 24, 2025 19:55
Copy link
Contributor

@Hallfred Hallfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, I commented some observations

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deviates somewhat from the setup used in vortex-auv, in that it here runs on pull_request, and the job name being coverage_build as opposed to call_reusable_workflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I checked on some other repositories and they have their code coverage to run on pull requests also, so I just copied that, but should update vortex-auv too. And should change name true true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test paths are not defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed to work fine without needing to specify it, I think its only if the filestructure is a mess (like vortex-auv)

@kluge7 kluge7 merged commit 3c42b9d into main Feb 24, 2025
3 of 4 checks passed
Copy link
Contributor

@Andeshog Andeshog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good enough 🤷

@kluge7 kluge7 deleted the ci/setup branch February 24, 2025 21:18
@kluge7 kluge7 restored the ci/setup branch February 25, 2025 09:19
@kluge7 kluge7 deleted the ci/setup branch February 25, 2025 10:13
@github-actions
Copy link

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants