average quat function #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 98.06% 97.04% -1.02%
==========================================
Files 5 5
Lines 413 440 +27
Branches 84 103 +19
==========================================
+ Hits 405 427 +22
- Misses 4 6 +2
- Partials 4 7 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Andeshog
reviewed
Dec 21, 2025
src/math.cpp
Outdated
Comment on lines
140
to
141
|
|
||
| Eigen::Matrix4d M = Eigen::Matrix4d::Zero(); |
Contributor
There was a problem hiding this comment.
A more appropriate name for this variable, which also follows the naming style, would be nice
Andeshog
reviewed
Dec 21, 2025
src/math.cpp
Outdated
Comment on lines
160
to
161
|
|
||
| Eigen::Vector4d eigenvector = eigensolver.eigenvectors().col(3); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.