Skip to content

Conversation

@jorgenfj
Copy link
Contributor

No description provided.

@jorgenfj jorgenfj requested a review from Andeshog December 22, 2025 13:45
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.86%. Comparing base (c89beaf) to head (c4a639c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   97.06%   96.86%   -0.20%     
==========================================
  Files           5        5              
  Lines         443      447       +4     
  Branches      106      108       +2     
==========================================
+ Hits          430      433       +3     
- Misses          6        7       +1     
  Partials        7        7              
Flag Coverage Δ
unittests 96.86% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/vortex/utils/types.hpp 96.10% <100.00%> (+0.51%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 158 to 159
return Pose{pos.x(), pos.y(), pos.z(), q.w(), q.x(), q.y(), q.z()};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In C++20 you can be more explicit with aggregate initialization, e.g.

return Pose{.x = pos.x(), .y = pos.y() // and so on

Also, just noticed, but change from eta to pose here either just in this PR or in a separate

Copy link
Contributor

@Andeshog Andeshog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, lgmt

@jorgenfj jorgenfj merged commit 92f430c into main Dec 22, 2025
5 checks passed
@jorgenfj jorgenfj deleted the feat/pose-from-eigen branch December 22, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants