iOS support.#36
Open
bdragon28 wants to merge 2 commits into
Open
Conversation
This does not yet handle migrating. I'm not sure what the best way to do this is, given the data structure change is in SharedObject. It's probably possible to scan through the objects with reflection, but if not, it might be necessary to add migration code to all types.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
* Rename the two-parameter Setup() to Upgrade() to describe better what it does. * Mark it abstract and implement it everywhere, to do a one-time copy of all of the Quest objects to iOS. * Document a bug in the Type_Light upgrade path, which was never actually run due to a typo.
Author
|
I added a migration path. I didn't get all clever with reflection, but went through every class and added migration code, for maintainability's sake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic iOS support.
This does not yet handle migrating. I'm not sure what the best way to do this is, given the data structure change is in SharedObject.
It's probably possible to scan through the objects with reflection, but if not, it might be necessary to add migration code to all types to initialize the fields.
Probably best to initialize it from the Quest values.