Skip to content

Conversation

@claudiu-iviteb
Copy link

What problem is this solving?

This adds the posibility to set different menus based on bindingIds.

How should this be manually tested?

Can be tested on this workspace: https://claudiumegamenu--iviteb.myvtex.com/

Screenshots or example usage:
image
image
image
image
image

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jun 15, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jun 15, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@cesarocampov
Copy link

https://claudiumegamenu--iviteb.myvtex.com/

hi @claudiu-iviteb nice start! there are some problems with the PR as it is
I tested the app on the workspace, i created a separate menu for binding bg. I do not see it on the admin when filtering for specific admin.
If i select ALL bindings it is shown.
Screenshot 2022-07-06 at 14 39 22
on the storefront it gets applied to ALL bindings:
https://claudiumegamenu--iviteb.myvtex.com/?__bindingAddress=iviteb.myvtex.com/
https://claudiumegamenu--iviteb.myvtex.com/?__bindingAddress=vtex.iviteb.com/es
https://claudiumegamenu--iviteb.myvtex.com/?__bindingAddress=vtex.iviteb.com/bg

@claudiu-iviteb
Copy link
Author

Hi @cesarocampov . Are you sure you created it for the bg binding? I see that the last one is set only for the 'es' binding, not 'bg'. And it seems to work as it should.

Copy link
Contributor

@ejisselgb ejisselgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution. I have some suggestions.

  1. Remove the option "admin" in the select, because the mega menu only will create menus in the store.
    image

  2. Add a title that allows you to identify in the interface the mega menu created to specific "binding".
    image

If you have questions, please, write me

Regards!

@claudiu-iviteb
Copy link
Author

Hi @ejisselgb . Just to confirm, you are suggesting to add the current selection of the binding dropdown, to the title area, right? I just want you to confirm that before implementing this along with the elimination of the admin binding. Thank you!

Copy link
Contributor

@ejisselgb ejisselgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @claudiu-iviteb yes, it's just adding the title to identify the menu that users will apply the changes.

cristian-milea pushed a commit to AuchanRomania/auchan.mega-menu that referenced this pull request Mar 24, 2023
cristian-milea pushed a commit to AuchanRomania/auchan.mega-menu that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants