-
Notifications
You must be signed in to change notification settings - Fork 18
Save and query menu by bindingId #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Save and query menu by bindingId #18
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
hi @claudiu-iviteb nice start! there are some problems with the PR as it is |
|
Hi @cesarocampov . Are you sure you created it for the bg binding? I see that the last one is set only for the 'es' binding, not 'bg'. And it seems to work as it should. |
ejisselgb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution. I have some suggestions.
-
Remove the option "admin" in the select, because the mega menu only will create menus in the store.

-
Add a title that allows you to identify in the interface the mega menu created to specific "binding".

If you have questions, please, write me
Regards!
|
Hi @ejisselgb . Just to confirm, you are suggesting to add the current selection of the binding dropdown, to the title area, right? I just want you to confirm that before implementing this along with the elimination of the admin binding. Thank you! |
ejisselgb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @claudiu-iviteb yes, it's just adding the title to identify the menu that users will apply the changes.

What problem is this solving?
This adds the posibility to set different menus based on bindingIds.
How should this be manually tested?
Can be tested on this workspace: https://claudiumegamenu--iviteb.myvtex.com/
Screenshots or example usage:




