This repository was archived by the owner on Dec 26, 2018. It is now read-only.
Prevent empty css#218
Open
pedro-mm-pereira wants to merge 1 commit intovuejs:masterfrom
pedro-mm-pereira:patch-1
Open
Prevent empty css#218pedro-mm-pereira wants to merge 1 commit intovuejs:masterfrom pedro-mm-pereira:patch-1
pedro-mm-pereira wants to merge 1 commit intovuejs:masterfrom
pedro-mm-pereira:patch-1
Conversation
Problems addressed: - When there are no styles on a Vue single-file-component and there is an out path defined in the extract-css plugin, the file is created anyway. - When the directory provided by the out path doesn't exist, the css file isn't created and the write action silently fails. This proposal tries to block the write action on empty styles (can be bypassed with the allowEmpty option) and creates the directory if it does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems addressed:
This proposal tries to block the write action on empty styles (can be bypassed with the allowEmpty option) and creates the directory if it does not exist.