Skip to content

Added option to log response body & code clean-up#5

Open
piranna wants to merge 6 commits into
vvo:masterfrom
SnowStormIO:master
Open

Added option to log response body & code clean-up#5
piranna wants to merge 6 commits into
vvo:masterfrom
SnowStormIO:master

Conversation

@piranna

@piranna piranna commented Apr 30, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@vvo

vvo commented May 15, 2018

Copy link
Copy Markdown
Owner

Hi @piranna I am no more using nor maintaining this library, would you like to be the new maintainer?

@vvo

vvo commented May 15, 2018

Copy link
Copy Markdown
Owner

Also the build is broken

@piranna

piranna commented May 15, 2018

Copy link
Copy Markdown
Collaborator Author

Hi @piranna I am no more using nor maintaining this library, would you like to be the new maintainer?

That's ok for me, so far I can be able to upload new versions to npm :-)

@vvo

vvo commented May 23, 2018

Copy link
Copy Markdown
Owner

What's your npm username so I can add you?

@piranna

piranna commented May 23, 2018

Copy link
Copy Markdown
Collaborator Author

What's your npm username so I can add you?

@piranna

@vvo

vvo commented May 23, 2018

Copy link
Copy Markdown
Owner

You now have access to both GitHub and npm publish, only ensure to make the tests pass (I am all in to switch to whatever testing system you prefer like jest), maybe deprecate some old nodejs versions and let's go.

If you have no time for that, let me know too. Thanks!

@piranna

piranna commented May 23, 2018

Copy link
Copy Markdown
Collaborator Author

If you have no time for that, let me know too

I'm a little bit bussy at this moment specially because my laptop got broken yesterday, but we can start by discussing this aspects :-) Yes, I think Jest is a good option, and to prevent pitfalls, I would configure TravisCI, coveralls and Greenkeeper too, what do you think?

@vvo

vvo commented May 23, 2018

Copy link
Copy Markdown
Owner

I would configure TravisCI, coveralls and Greenkeeper too, what do you think?

Well it's super good yep. Then prettier, eslint are also great ways to make this project even more future proof. Along with instructions on how to release it so anyone can contribute to it.

I like lerna and standard-version for those kind of automation.

About greenkeeper, I am myself using renovate but if you are a greenkeeper go for it!

@vvo

vvo commented Jun 21, 2018

Copy link
Copy Markdown
Owner

@piranna let me know when you want a review, right now only missing part is README I believe, and maybe some linting/prettier installation

@piranna

piranna commented Jun 21, 2018

Copy link
Copy Markdown
Collaborator Author

I like lerna and standard-version for those kind of automation.

I don't like lerna, and for this project would not be needed. Don't know of standard-version, can you point me to it?

About greenkeeper, I am myself using renovate but if you are a greenkeeper go for it!

Interesting, do you have a link for renovate?

@piranna let me know when you want a review, right now only missing part is README I believe, and maybe some linting/prettier installation

You can take a look if you want. The last part about the text field can be removed, it was a misunderstood on my side.

@piranna

piranna commented Jun 21, 2018

Copy link
Copy Markdown
Collaborator Author

Currently I was doing some clean-ups and code updates, like using object destructuring or removing req.log, since I think doesn't make sense in a middleware like this.

@vvo

vvo commented Jun 21, 2018

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants