Fix compatibility with Laravel 12.34

[FrittenKeeZ]

Described in #635 and #636 - implementing the direct fix from the latter.

[FrittenKeeZ]

@khepin @vyuldashev can one of you take a look at this?

[alexeydotsenko]

Looks like just

protected $config;

public function getConfig(): QueueConfig
{
    return $this->config;
}

public function setConfig(array $config)
{
    $this->config = QueueConfigFactory::make($config);

    return $this;
}

will be enough

[FrittenKeeZ]

@alexeydotsenko nope, Laravel's $config is expected to be an array.

[alexeydotsenko]

They do not lock a type of $config variable to array. According to a code configuration will be provided as array, but we can store it in any format. So we can do it without extra code changes

[FrittenKeeZ]

That is very risky, since usage of getConfig() might cause fatal errors in the future if the using code expects an array.
Otherwise QueueConfig should implement the necessary interfaces to act like an array.

[duykb2015]

Oh my. Please review this - my app is down now 😭

[FrittenKeeZ]

@duykb2015 downgrade to Laravel 12.33 for now.

[duykb2015]

@FrittenKeeZ it’s all good now. I copied your file and it’s working. Thank you so much, you saved me!

[Crmteam-IVG]

Please review the changes @khepin @vyuldashev

[dzatona]

Temp workaround: #639 (comment)

[mihob]

@khepin @vyuldashev Any news on this?

[FrittenKeeZ]

Tests are failing because #628 hasn't been merged

[Shabandinh0]

@vyuldashev Any news on this?

[reddinan]

@vyuldashev Are you going to look at this or should we fork?

[khepin]

@FrittenKeeZ can you pull the latest master in your branch to rerun the tests

[FrittenKeeZ]

@khepin it should be ready for workflows now

[FrittenKeeZ]

@khepin it's throwing errors in files I haven't even touched - what's going on?

[khepin]

I am not sure what's going on. Are you able to run those failing tests locally and see if the same errors happen. Seems to be only for some version combinations of PHP/Laravel

[FrittenKeeZ]

@khepin I get the same errors locally running PHP 8.4 and Laravel 12 / Testbench 10

Edit: Apparently it's all Feature\SslQueueTest tests not being skipped which causes the errors

[FrittenKeeZ]

@khepin I think I solved the issue with tests not being properly skipped - can you run the workflow again?