Fix: Remove some confusing wording regarding all JSON objects being AS2 Object#770
Open
trwnh wants to merge 2 commits into
Open
Fix: Remove some confusing wording regarding all JSON objects being AS2 Object#770trwnh wants to merge 2 commits into
trwnh wants to merge 2 commits into
Conversation
Fix w3c#706 Note that "everything is an extension of Object" is still in effect due to the next paragraph's last sentence containing the clause after the semicolon.
trwnh
changed the title
TallTed
reviewed
Jun 8, 2026
| <code><a>Object</a></code> or a <code><a>Link</a></code>. All other types | ||
| defined in the Activity Vocabulary, as well as all extension types, are | ||
| derived from these two base types. | ||
| All other types |
Member
There was a problem hiding this comment.
Saying "all" and then immediately proceeding to "one exception" (which implies there are more) is problematic. There might be something better than "Nearly all", like "Virtually all", "With a few exceptions, all", etc.
Suggested change
| All other types | |
| Nearly all other types |
Author
There was a problem hiding this comment.
"All other types" is correct"; I guess the real problem is that "One exception" is not really an exception. It's more of a note on disjointness. I'm noticing now that Links is actually already mentioned in the list as the 2nd item.
There is a possibility that the next paragraph may be reworked or removed entirely, as it's part of other issues. I'll remove lines 636-637 to avoid further confusion.
trwnh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #706