Skip to content

Adds dark mode and simplify CSS#33

Open
Tpt wants to merge 2 commits into
mainfrom
tpt/dark-mode
Open

Adds dark mode and simplify CSS#33
Tpt wants to merge 2 commits into
mainfrom
tpt/dark-mode

Conversation

@Tpt

@Tpt Tpt commented Mar 5, 2025 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
  • use http syntax highlight instead of req/resp nohighlight, it draws a box in both light and dark mode
  • use default pre style for sparql, migrate to the sparql style in the hope of a syntax highlighter
  • drop the style block that is unused

Preview | Diff

@Tpt Tpt requested review from afs, kasei and rubensworks March 5, 2025 13:40
@Tpt Tpt self-assigned this Mar 5, 2025
afs
afs reviewed Mar 6, 2025
View reviewed changes

@afs afs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table styling in 2.1 and 2.2 isn't happening anymore.

@afs afs self-requested a review March 6, 2025 08:35
@Tpt Tpt added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Mar 20, 2025
@Tpt

Tpt commented Mar 20, 2025

Copy link
Copy Markdown
Author

I have added back table styling using class="data"

@Tpt Tpt mentioned this pull request Jun 24, 2025
Merged
Tpt and others added 2 commits May 21, 2026 18:35
@Tpt
* use http syntax highlight instead of req/resp nohighlight, it draws…
dc718ec 
… a box in both light and dark mode

* use default pre style for sparql, migrate to the sparql style in the hope of a syntax highlighter
* drop the style block that is unused
@Tpt
Rebase
7001f37
@Tpt Tpt force-pushed the tpt/dark-mode branch from 257feed to 7001f37 Compare May 21, 2026 16:38
@Tpt

Tpt commented May 21, 2026

Copy link
Copy Markdown
Author

MR rebased

@afs

afs commented May 24, 2026

Copy link
Copy Markdown
Contributor

Is this change of borders intentional?

Current:
image

Proposed:
image

@afs

afs commented May 24, 2026

Copy link
Copy Markdown
Contributor

The light mode boxes are quite faint grey which might be raised in accessibility review:

e.g.
image

not that the current document is good for perfect request and response but the query boxes are distinguished:
image

@Tpt

Tpt commented May 24, 2026

Copy link
Copy Markdown
Author

Is this change of borders intentional?

Yes, This MR adopts the styles of data tables from tr-design.

The light mode boxes are quite faint grey which might be raised in accessibility review:

This is the ReSpec styling for <pre. I guess that if accessibility raises something it should be fixed in ReSpec?

@afs

afs commented May 24, 2026

Copy link
Copy Markdown
Contributor

IMO the large text blocks don't work very well. The tr-design illustration is one or two words per cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domel domel domel approved these changes
@kasei kasei Awaiting requested review from kasei
@rubensworks rubensworks Awaiting requested review from rubensworks
@afs afs Awaiting requested review from afs

Assignees

@Tpt Tpt

Labels

spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tpt @afs @domel @pchampin