안드로이드 리프레시 토큰 추가#140
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb472cbddc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return ResponseEntity.ok( | ||
| AndroidTokenResponse( | ||
| accessToken = issued.accessToken, | ||
| refreshToken = issued.refreshToken |
There was a problem hiding this comment.
For Android clients that get their refresh token from this JSON field, the token is not handled by the existing logout flow: AuthController.logout only reads @CookieValue and UserService.logout returns immediately when that cookie is absent, and there is no /android/logout or body/header-based revocation path in the repo. Unless every Android caller manually re-encodes this body token as a Cookie header, these refresh tokens remain usable until the 14-day refresh expiry after app logout, so add a logout/revocation path that accepts the Android token format.
Useful? React with 👍 / 👎.
|
혹시 저 코덱스가 지적한 부분 크게 상관 없는 건지 한번만 확인 부탁드려도 괜찮을까요? |
|
안드로이드 전용 로그아웃 엔드포인트가 필요할 것 같습니다 |
|
로그아웃 엔드포인트 추가하여 머지했습니다. 리뷰 감사합니다. |
3 participants
#️⃣ 연관된 이슈
📝 작업 내용
✅ 체크리스트
스크린샷 (선택)
💬 리뷰 요구사항(선택)