Skip to content

Conversation

@pleschev
Copy link

Test case that shows code being cleaned up, when we'd expect it to be left alone.

@pleschev pleschev changed the title Recreates #4 Failure scenarios when dealing with lambdas Mar 5, 2018
@pleschev
Copy link
Author

pleschev commented Mar 5, 2018

testDontRemoveImportsUsedByLambdas() has been fixed by rpau/javalang-compiler#78 - Thank you

testDontRemoveImportsUsedByLambdasExample2() should be fixed by rpau/javalang-compiler#79

testDontRemoveImportsUsedByLambdasExample3() is another failing scenario, not sure how to fix or recreate the problem in javalang-compiler. Guidance would be much appreciated

@rpau
Copy link
Collaborator

rpau commented Mar 13, 2018

@pleschev I have fixed the third issue here: rpau/javalang-compiler#81
Issues like these should be added in rpau/javalang-compiler inside of SymbolVisitorAdapterTest. You can find your issues there.

The main components of this project are SymbolVisitorAdapter which creates the symbols and marks the usages; and TypeVisitorAdapter which resolves the type of each symbol and expression.

Now I will continue with the second issue (which the problem appears because the lambda is assigned into a variable).

@pleschev
Copy link
Author

Thank you, much appreciated!

@rpau
Copy link
Collaborator

rpau commented Mar 26, 2018

Fixed here: rpau/javalang-compiler#82
I will generate release tomorrow :)
Thanks again for creating such clear and simple test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants