Make compile script retry if a 409 is encountered#3
Open
mltsy wants to merge 1 commit intowamazing:masterfrom
Open
Make compile script retry if a 409 is encountered#3mltsy wants to merge 1 commit intowamazing:masterfrom
mltsy wants to merge 1 commit intowamazing:masterfrom
Conversation
For some reason the existing method for comparing existing files doesn't always pick up on existing files (at least in a Next build). This results in a 409 when trying to overwrite them. Here, we catch that error and update the file instead.
mltsy
commented
May 22, 2024
Comment on lines
+95
to
+96
| else | ||
| echo " Failed to upload ${map}, status code: $status" |
Author
There was a problem hiding this comment.
Not sure if this is what we want here... maybe we want it to just fail?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the existing method for comparing existing files doesn't always pick up on existing sourcemap files (at least in a Next build)
This results in a 409 when trying to upload such files. Here, we catch that error and update the file instead.