style: apply /style-guide pass to models/artifacts#2717
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
📚 Mintlify Preview Links📝 Changed (12 total)📄 Pages (12)
🤖 Generated automatically when Mintlify deployment succeeds |
🔗 Link Checker ResultsChecked against: https://wb-21fd5541-style-guide-models-artifacts-20260603-165211.mintlify.app Summary
Errors per inputErrors in models/artifacts/track-external-files.mdx
|
There was a problem hiding this comment.
Pull request overview
This PR applies automated style-guide edits across the Models → Artifacts documentation set, primarily improving wording consistency, headings, and adding frontmatter keywords to support discoverability.
Changes:
- Added
keywordsmetadata and refined intros/notes for clarity and consistency across multiple Artifacts docs pages. - Standardized placeholder formatting in many code examples (toward bracketed placeholders) and tightened procedural language.
- Restructured some sections/headings (for example, converting subheadings to top-level sections where appropriate).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| models/artifacts/artifacts-walkthrough.mdx | Reworded walkthrough steps and improved narrative flow; added keywords. |
| models/artifacts/construct-an-artifact.mdx | Clarified construction steps and examples; added keywords; updated tables and links. |
| models/artifacts/create-a-custom-alias.mdx | Refined alias explanation and placeholder formatting; added keywords. |
| models/artifacts/create-a-new-artifact-version.mdx | Expanded explanations for single/distributed/incremental versioning; added keywords. |
| models/artifacts/data-privacy-and-compliance.mdx | Improved framing around storage, deletion, and retention; added keywords. |
| models/artifacts/delete-artifacts.mdx | Improved explanations around soft-delete/GC and deletion flows; added keywords. |
| models/artifacts/download-and-use-an-artifact.mdx | Updated terminology/formatting and added keywords; clarified use_artifact() return type. |
| models/artifacts/explore-and-traverse-an-artifact-graph.mdx | Improved lineage graph explanation, placeholders, and navigation language; added keywords. |
| models/artifacts/storage.mdx | Added keywords; adjusted cache cleanup section formatting. |
| models/artifacts/track-external-files.mdx | Clarified reference artifact behavior and external storage guidance; added keywords. |
| models/artifacts/ttl.mdx | Reworked TTL overview and procedures; added keywords; updated placeholders and UI steps. |
| models/artifacts/update-an-artifact.mdx | Refined intro and examples; added keywords; improved wording around API vs in-run updates. |
Comments suppressed due to low confidence (1)
models/artifacts/ttl.mdx:177
- The "outside of a run" example uses
wandb.Api()andtimedelta(...)but doesn't importwandbortimedelta, so it won't run as-is.
api = wandb.Api()
artifact = api.artifact("[ENTITY]/[PROJECT]/[ARTIFACT]:[ALIAS]")
artifact.ttl = timedelta(days=365) # Delete in one year
artifact.save()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Incorporate all 15 inline Copilot review comments plus the suppressed low-confidence comment: - construct-an-artifact: fix `&` in the "save your artifact" anchor (#3-...-wb-server); use a directory path in the add_dir example. - create-a-new-artifact-version: correct the inaccurate "version greater than 1" claim; fix `wanb.Artifact` typo. - download-and-use-an-artifact: keyword wandb.Api (was "wandb Api"). - explore-and-traverse-an-artifact-graph: add missing article; point the "inputs" cross-reference at #track-the-input-of-a-run; use the canonical name:alias form in use_artifact instead of aliases="<str>". - storage: drop "memory allocation" from title/description (body only covers disk storage and cache cleanup). - track-external-files: standardize on "CoreWeave AI Object Storage"; complete the "Add and download an external file from a bucket" heading. - ttl: complete two truncated UI steps; make the four Python snippets runnable by wrapping run.use_artifact in wandb.init() and adding the missing wandb/timedelta imports. - update-an-artifact: the in-run path uses Artifact.save(), not wandb.Run.save(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Addressed review feedback in ab69750Thanks for the review! I incorporated all 15 inline comments plus the suppressed low-confidence comment, and replied inline on each thread. Summary: Technical accuracy / runnable examples
Links / anchors / metadata
Wording / consistency
I also fixed two clear errors flagged in the PR description while I was in those files: the Left for technical/SME review (as the PR description requests): the deeper product-accuracy questions (e.g., the 10,000-object prefix cap, Azure URI support, the |
…t-an-artifact.mdx main's #2751 and this PR are two independent style passes on construct-an-artifact.mdx. Conflict resolution: - Adopt main's de-numbered H3 headings (Create… / Add… / Save…) and their de-numbered self-link anchors. - Carry this PR's fix forward onto main's direction: the step-3 anchor drops the raw "&" (#save-your-artifact-to-the-wb-server); main's version still contained the unescaped "&". - Keep this PR's wording where it is a superset or more active-voice: the URI-reference intro sentence, and "W&B might log artifacts" (W&B as actor). - Update ttl.mdx's cross-reference to the de-numbered anchor (#save-your-artifact-to-the-wb-server). This also fixes a latent broken link main introduced by de-numbering the heading without updating callers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Remove the `keywords` frontmatter added in this PR across all 12 models/artifacts pages. No other content changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-and-use-an-artifact.mdx main's seats/roles consistency pass renamed the seat to "Models Viewer seat"; this PR's style pass applied the contraction. Resolution keeps main's authoritative seat terminology with the style-guide contraction: "Team members with a Models **Viewer** seat can't download artifacts." Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
First two pages reviewed. The comments left here apply to all. |
|
I think these agentic edits are trying to do too much. Consider having multi-agentic flows. One agent should only act as tech editor (check, fix style NOT add text). Another agent could be used to add supplemental intros. TBH, I'd say that (anecdotally) 50% are useful. There others are not. |
Reviewed pages (artifacts-walkthrough, construct-an-artifact): - Apply task-oriented intro and wording suggestions verbatim. - Drop made-up "artifact graph" term and the confusing "pull it into other runs as a tracked input" sentence. - Remove redundant added intro on construct-an-artifact (description + existing intro already cover it); combine the wordy URI-reference sentences; drop the "populate" filler. - Fix the step-3 anchor: Mintlify keeps the ampersand, so the working slug is #save-your-artifact-to-the-w&b-server (verified against the live preview heading id). Also fix the same cross-reference in ttl.mdx. Applies-to-all: - Revert placeholder style from [ALL-CAPS]/[BRACKETS] back to angle-bracket lowercase (<name>, <type>, …) across every artifacts page — 86 tokens in 8 files. Square brackets read as Python lists and ALL-CAPS reads as env/global vars (per ngrayluna). - Remove the redundant "This page shows you how to …" prepended intros on create-a-new-artifact-version, delete-artifacts, and download-and-use. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thanks @ngrayluna — applied your comments to the two reviewed pages and extended the "applies to all" guidance across the set (pushed in
Replies are on each inline thread and the threads are resolved. |
Per review: a tech-edit pass should fix style, not add text. Revert the content this PR added and restore original wording, especially on the Eng-reviewed ttl.mdx. - ttl: restore the original intro and the "set default TTL for a team" wording; restore the three Python snippets to their original form (no `with wandb.init()` — deliberately written without a context manager so editing a TTL doesn't create a new run); keep `<>` shown in placeholder instructions. - create-a-new-artifact-version: drop the duplicated "avoids re-uploading" clause; revert the awkward distributed-runs sentence; "## Create new artifact versions"; `wandb.Run.upsert_artifact()`; "previous" not "preceding"; "larger" not "much larger". - delete-artifacts: apply ngrayluna's wording for the GC-diagram lead-in, soft-delete note, multi-version intro, alias-filter intro, collection deletion (drop unconfirmed data-usage claim), and deployment-type para. - explore: remove the audience callout and the stray "Lineage tab" line; revert use_artifact to `artifact_or_name=..., aliases=...`; show `< >`. - track-external-files: "behave similar to"; restore the download lead-in. - download-and-use: restore "First, … Next, …" sequencing. - storage: explain the cache-size example. - update-an-artifact: "linked to a collection in the W&B Registry". Placeholders remain angle-bracket lowercase (`<name>`) per ngrayluna. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Pushed
All inline threads are replied to and resolved, except the list-numbering question on On your structural suggestion (separate tech-editor vs. intro-writer agents): that's good feedback for the One open item for the team, not this PR: placeholder style. This PR now uses |
Summary
This PR applies the
/style-guideskill (Google Developer Style Guide + CoreWeave conventions) to the Models / Artifacts documentation. The run was fully automated — only style-level edits were made, and all flagged technical issues are surfaced below for human review.Files edited
models/artifacts/artifacts-walkthrough.mdxmodels/artifacts/construct-an-artifact.mdxmodels/artifacts/create-a-custom-alias.mdxmodels/artifacts/create-a-new-artifact-version.mdxmodels/artifacts/data-privacy-and-compliance.mdxmodels/artifacts/delete-artifacts.mdxmodels/artifacts/download-and-use-an-artifact.mdxmodels/artifacts/explore-and-traverse-an-artifact-graph.mdxmodels/artifacts/storage.mdxmodels/artifacts/track-external-files.mdxmodels/artifacts/ttl.mdxmodels/artifacts/update-an-artifact.mdxRecommendations for technical review
Prerequisites
artifacts-walkthrough.mdx,construct-an-artifact.mdx,create-a-custom-alias.mdx,create-a-new-artifact-version.mdx,download-and-use-an-artifact.mdx,explore-and-traverse-an-artifact-graph.mdx,track-external-files.mdx,ttl.mdx, andupdate-an-artifact.mdxlisting required setup (installedwandbSDK, authenticated session, project/entity access, and any page-specific prerequisites such as cloud credentials,boto3, or an existing artifact).artifacts-walkthrough.mdx: the "Add the dataset to the artifact" step assumes the reader has a localdataset.h5file. Consider linking to a sample dataset.ttl.mdx: the "Set or edit a TTL policy → Python SDK" snippet usesrun.use_artifact(...)without a priorwandb.init(...), and the "outside of a run" snippet usestimedelta(...)without showing thefrom datetime import timedeltaimport. Confirm whether leading context should be added.Verification steps
artifacts-walkthrough.mdx,construct-an-artifact.mdx,create-a-custom-alias.mdx,create-a-new-artifact-version.mdx,delete-artifacts.mdx,download-and-use-an-artifact.mdx,explore-and-traverse-an-artifact-graph.mdx,storage.mdx,track-external-files.mdx,ttl.mdx, andupdate-an-artifact.mdx.create-a-custom-alias.mdx: after logging withbest-ap50, describe where the alias appears in the W&B UI or how to verify it via the API.ttl.mdx:print(artifact.type)under "Autogenerated artifacts" has no expected output — clarify which value indicates an autogenerated vs. user-generated artifact.Technical accuracy
construct-an-artifact.mdx: the Tip block contrastswandb.Run.log_artifact()withArtifact.save(), butArtifact.save()is never demonstrated or linked.artifact.new_file('hello.txt')appears in the API-call table without prior introduction. Verify the supported URI scheme list (http(s)://,s3://,gs://) — Azure support may be missing. Re-verify the 10,000-object cap on S3/GCS prefix expansion and the "faster uploads" rationale for asynclog_artifact()calls.create-a-custom-alias.mdx: clarify what "changed" means in the checksum/dedup sentence (are identical re-logs deduplicated?). The example artifact namerun-3nq3ctyy-bike-modellooks autogenerated — confirm intentional or replace.AP-50is domain-specific; consider a more generic alias example.create-a-new-artifact-version.mdx: Line 58 misspellswanb.Artifact(should bewandb.Artifact). Line 21 says the retrieved artifact "has a version greater than 1" while the example progressesv0→v1— verify intended wording. Image alt text (Artifact workflow comparison,Incremental artifact versioning) is generic — consider more descriptive alt text.download-and-use-an-artifact.mdx: confirm the Pass 8 correction at line 34 thatuse_artifact()returns an artifact object (not a run object), and verify the placeholder explanations for[PROJECT-NAME]and[JOB-TYPE].explore-and-traverse-an-artifact-graph.mdx: line 93 the "inputs" cross-reference appears to be missing the#track-the-input-of-a-runfragment. Line 42 "view the type and the name of artifact" likely needs an article ("of the artifact" / "of an artifact"). Line 140 conflates two ideas and repeats "cluster" three times — consider splitting.storage.mdx: confirm the "To change default location set:" column header reads naturally given the cells; verify1GBis the literal CLI argument format (vs.1 GB/1G); confirm "during training" framing applies outside training contexts.track-external-files.mdx: line 109 heading "Add and download an external from a bucket" is missing a noun. Line 7 lists "HTTP file server" as supported but no example is provided. Line 121boto3call usesfile_name=,bucket=,object_name=— typicalboto3.upload_file()parameters areFilename,Bucket,Key. Product-name inconsistency: "CoreWeave Storage and MinIO" vs. "CoreWeave AI Object Storage" — pick one. Confirm'Object Versioning'is the literal UI label across providers. Lines 184–193 use<entity>/<project>angle-bracket placeholders rather than the[ALL-CAPS]convention preferred by CoreWeave AGENTS.md.ttl.mdx: lines 130 and 203 sentences end mid-thought ("expand the artifact type you"). Step 4 of "Set default TTL policies for a team" has an ambiguous trailing object ("Click the Set team's default TTL policy"). Verify the Link to registry button is still the correct landmark in the UI. ConfirmcreatedAtfield name (vs.created_at). Line 18 "permitting who can set or edit a TTL policy" reads awkwardly.update-an-artifact.mdx: the intro says "Usewandb.Run.save()to update an artifact," but the "During a run" example usesartifact.save()— confirm which method is correct. Confirmmetadataandaliasesare also updatable during a run. Verify theapi.artifact_collection(type=..., collection=...)signature and whether callingwandb.Api()insidewandb.init()is intentional.Missing content
artifacts-walkthrough.mdx: clarify whether the final example assumes a fresh script/session, and consider explicit comments linking numbered steps to corresponding code lines.construct-an-artifact.mdx: gloss or link "directed acyclic graph" andPartitionedTable/PartitionTable. Step 2 says "See the next section, Add files to an artifact" but the linked target is actually Step 3. The anchor#3-save-your-artifact-to-the-w&b-servercontains an unencoded&; the Mintlify slug likely strips it (probably#3-save-your-artifact-to-the-wb-server). The three H3 headings retain numbering (### 1.,### 2.,### 3.) — left as-is to preserve anchors, but worth a coordinated cleanup.create-a-custom-alias.mdx: add a one-line definition of "alias" up front; add cross-references towandb.Artifact,Run.log_artifact,Run.use_artifact; reconsider the page title ("Create an artifact alias" vs. "Create a custom artifact alias").create-a-new-artifact-version.mdx: terms likegroup,wandb.Api(),use_artifact, andnew_draft()are unlinked. Link the Python SDK reference. Distributed mode failure modes (e.g.,finish_artifactcalled before allupsert_artifactcalls complete, mismatcheddistributed_id) may warrant a Caution notice. The commented-out<Note>at lines 213–215 is dead content — restore or delete.data-privacy-and-compliance.mdx: define or link "soft deletion"; link directly to how to configure Dedicated Cloud retention (not just the overview); consider an inline gloss for "reference artifacts"; consider section headings (Storage / Deletion / Retention / Sensitive data).download-and-use-an-artifact.mdx: the W&B CLI tab needs context for when to prefer CLI over the Python API; the trailingEntry.download/Entry.refbullets lack an outcome statement; the commented-out "Track external files" reference at line 79 should be restored or removed.explore-and-traverse-an-artifact-graph.mdx: the<Note>block at lines 41–43 may not warrant a notice per style guide. "Artifact clusters" should cross-link to the earlierlineage_multiple_artifact_versions.pngimage. Lines 7–8 and line 32 contain near-duplicate definitions of "lineage graph" — trim one.storage.mdx: the Warning about non-writable filesystems lacks remediation (e.g., setWANDB_DIRto a writable path). The page title mentions "memory allocation" but the body covers only disk storage and cache cleanup — narrow the title or add memory content. If non-US storage regions are available, link the region-selection docs.track-external-files.mdx: line 168 has an orphaned MDX comment; lines 270–280 contain a large commented-out "Log artifacts outside of runs" block — restore or remove.max_objects=(lines 82, 222) needs explanation of valid values and trade-offs.AWS_S3_ENDPOINT_URLandAWS_REGIONare referenced without setup guidance.ttl.mdx: commented-out<Note>(lines 183–185) references a non-existent## Inherit TTL Policysection — restore or remove. The two adjacent<Note>blocks at the top (lines 14–20) overlap and could be consolidated. Image filename typo:remove_ttl_polilcy.gif→remove_ttl_policy.gif. TheColabLinknotebook URL points to a feature branch (kas-artifacts-ttl-colab) rather thanmaster— verify reachability.update-an-artifact.mdx: link "Model Registry" and define "linked" in the Model Registry warning; clarify when an artifact is "active" vs. when to use the Public API; the "Artifacts Collection" link text targets a generic Public API reference — confirm or update.Placeholder and naming conventions
[MY-PROJECT-NAME]vs.[MY-PROJECT]vs.[PROJECT];[MY-ARTIFACT-NAME]vs.[ARTIFACT];<entity>angle-bracket vs.[ENTITY]bracket). Consider a coordinated cleanup to standardize on one convention (for example,[ENTITY],[PROJECT],[ARTIFACT],[ALIAS],[TYPE]).construct-an-artifact.mdx: "W&B server" appears lowercase in two headings but "W&B Server" appears as a proper noun elsewhere — confirm whether headings refer to the self-managed Server product or to the backend generically. "W&B Runs" as a linked first mention may warrant lowercasing per the "features become lowercase" rule.How to review