style: apply /style-guide pass to models/registry#2721
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
📚 Mintlify Preview Links📝 Changed (11 total)📄 Pages (11)
🤖 Generated automatically when Mintlify deployment succeeds |
🔗 Link Checker Results✅ All links are valid! No broken links were detected. Checked against: https://wb-21fd5541-style-guide-models-reports-20260604-104120.mintlify.app |
|
Update PR title. This PR touches Reports, not Registry. |
85d1194 to
07e5bdc
Compare
|
@ngrayluna good catch — rather than rename, I force-pushed this branch to the intended registry content. The head ref still reads The reports content that was previously here is unaffected and already covered by #2723.
|
There was a problem hiding this comment.
Pull request overview
This PR applies automated style-guide edits to the W&B Registry documentation under models/registry, primarily improving wording, structure, and frontmatter metadata (for example, adding keywords) across multiple pages.
Changes:
- Adds/normalizes frontmatter
keywordsand updates introductory copy for clarity and consistency. - Refines procedural steps, headings, and UI/SDK descriptions across registry docs.
- Updates/normalizes links and reference wording (with some link-target regressions that need correction).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| models/registry/aliases.mdx | Rewrites intro and alias guidance; updates SDK instructions and examples. |
| models/registry/configure_registry.mdx | Reworks access/roles content and improves descriptions and tables. |
| models/registry/create_collection.mdx | Clarifies collection concepts and improves SDK/UI instructions and examples. |
| models/registry/create_registry.mdx | Updates registry creation instructions and visibility explanation. |
| models/registry/delete_registry.mdx | Expands intro and clarifies deletion steps/roles. |
| models/registry/download_use_artifact.mdx | Clarifies how to construct and use registry artifact paths and where to get UI snippets. |
| models/registry/lineage.mdx | Improves lineage/audit explanations and step clarity. |
| models/registry/link_version.mdx | Refines linking workflow narrative and step wording for UI/SDK paths. |
| models/registry/organize-with-tags.mdx | Expands tag vs alias guidance and refines UI/SDK instructions text. |
| models/registry/registry_cards.mdx | Improves guidance on annotating collections and SDK usage wording. |
| models/registry/search_registry.mdx | Improves query/search explanation and example framing; adds keywords. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolve the 8 Copilot review comments on #2721: - create_registry.mdx: fix broken anchor #registry-visibility-types -> same-page #visibility-types; fix broken self-link #create-a-custom-registry -> #create-a-registry. - create_collection.mdx: print() received a generator expression; wrap in a list comprehension so the example outputs artifact type names. - aliases.mdx: repoint two broken #registry-roles links to #role-permissions; fix `alias` -> `aliases` parameter name and the link_artifact() reference (run.md/#link_artifact -> run/#method-runlink_artifact). - registry_cards.mdx: correct the collection full-name prefix wording (`wandb-registry` -> `wandb-registry-`) to match the format example. - configure_registry.mdx: add a backward-compatibility #registry-roles anchor so out-of-scope and localized inbound links keep resolving. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thanks for the review! I've pushed f1f7b2c addressing all 8 Copilot comments. Summary: Broken anchors / links
Correctness
Backward compatibility (one judgment call)
Note: localized @ngrayluna ready for re-review against the registry pages whenever you have a moment. |
Remove the `keywords` frontmatter field added to all 11 models/registry pages during the style-guide pass. None of these pages had a keywords field on main; this restores that. All other style edits are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolve conflict in models/registry/lineage.mdx: combine main's updated example names (zesty-snowball-7, split_zoo_dataset:v0, zoo-qne08r7u:v0, glamorous-planet-8) and the new "Create a custom view" section with the style-guide pass's wording and backtick formatting. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolve conflicts in 5 models/registry pages. For each, keep the style-guide pass's wording and drop the embeds for the GIFs that #2764 deleted (so no broken image links), while preserving main's substantive changes: the simplified "Confirm the path" section in link_version.mdx, the service-account footnote cross-reference in configure_registry.mdx, and the tag-example rename in organize-with-tags.mdx. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Summary
This PR applies the
/style-guideskill (Google Developer Style Guide + CoreWeave conventions) to themodels/registrysection. The run was automated; all edits are style-only and require human review before merge.Files edited
models/registry/aliases.mdxmodels/registry/configure_registry.mdxmodels/registry/create_collection.mdxmodels/registry/create_registry.mdxmodels/registry/delete_registry.mdxmodels/registry/download_use_artifact.mdxmodels/registry/lineage.mdxmodels/registry/link_version.mdxmodels/registry/organize-with-tags.mdxmodels/registry/registry_cards.mdxmodels/registry/search_registry.mdxRecommendations for technical review
Prerequisites
wandb loginauthentication, and any Server version gates — applies toaliases.mdx,configure_registry.mdx,create_collection.mdx,create_registry.mdx,download_use_artifact.mdx,link_version.mdx,organize-with-tags.mdx,registry_cards.mdx.lineage.mdx: confirm whether viewer-level access is sufficient to view lineage graphs and Action History, or whether Registry admin/member roles are required.organize-with-tags.mdx: the intro Note compares tags to aliases without linking to the aliases doc — consider adding the link.Verification steps
create_registry(),fetched_registry.delete(),collection.save(), andlink_artifact().aliases.mdx: the "Find existing aliases" procedure does not describe what an unsuccessful search looks like.organize-with-tags.mdx: add verification snippets (e.g., re-fetchcollection.tags) after add/update/remove tag examples, and confirm whether.save()is implicitly required for the update flows.Technical accuracy
aliases.mdx: confirm whetherentityvaluesmle-reg-team-2in the Example is intentional or should be a placeholder; verify the#custom-aliasescross-reference for "non protected alias" on line 54.configure_registry.mdx: verify UI labels (both Add access buttons in steps 4 and 6), the Service account (non-admin) vs. User or service account (non-admin) row overlap, the Multi-tenant Cloud "Restricted Viewer" version qualifier, the cross-registry access summary wording, and the lone#### SDK compatibilityH4. Normalize bare URLs across the three procedures and verify the raw<sup><a>footnote markup renders in Mintlify.create_collection.mdx:print(artifact_type.name for artifact_type in artifact_types)on line 95 prints a generator object — likely a bug. Confirm the "Python SDK (Beta)" tab label is still current; verifywandb.Api().project(...).artifact_types()signature and.nameattribute; confirm thetarget_pathformatwandb-registry-{registry_name}/{collection_name}(some docs include an entity prefix); clarify how artifact type is determined whenlink_artifactauto-creates a collection; verify the UI label ("Artifact" vs. "Artifact collection") and the correct term for artifact-type indicators on the registry card.create_registry.mdx: broken anchor on line 87 —./create_registry#create-a-custom-registrydoes not exist (only#create-a-registry). Confirm whether registry visibility is exhaustively two options (Restricted, Organization). Consider promoting the line-43<Note>about irreversible artifact-type saves to a<Warning>.delete_registry.mdx: confirm whetherapi.registry("[REGISTRY-NAME]")requires an organization/entity scope in addition to the name.download_use_artifact.mdx: confirm the path templatewandb-registry-{REGISTRY}/{COLLECTION}:{ALIAS}and the preferred reference form (wandb.Run.use_artifact()vs.run.use_artifact()). The<Note>block on lines 98–114 contains a possibly redundant secondwandb.Api()instantiation — confirm whether it's intentional. Confirm the mixed f-string{REGISTRY}vs. angle-bracket<registry_name>placeholder convention is intentional.lineage.mdx: confirm exact UI elements — step 3 "From the dropdown" is ambiguous, and verify Action History capitalization. Decide whether to restore or remove the commented-out block at lines 84–88.link_version.mdx: verify the renumbered W&B Registry tab (now 8 steps) didn't drop a step at the original duplicate5.; confirm step order in the Artifact browser tab; consider splitting the recovery instruction at step 3 of Log from a team entity out of the numbered list; confirm the Select a register model UI label spelling (registervs.registry). Decide whether the four commented-out<Note>blocks (lines 28–30, 34–36, 47–49, 165–170) should be surfaced or deleted.organize-with-tags.mdx: the artifact-versionView tagsSDK example uses lowercaseartifact_typewhileARTIFACT_TYPEis defined above — likely a bug. Thecollection.tags = set(collection.tags) - set(tags_to_delete)pattern references an undefinedtags_to_deleteand assigns asetwhere the attribute may expect a list.collection.tags = ["your-tag"]overwrites rather than appends — confirm whether section title "Add a tag" matches behavior. Verifywandb.Api().artifact_collectionandwandb.Api().artifactsignatures. The hardcodedhttps://wandb.ai/registryURL needs a Dedicated Cloud / self-managed caveat.registry_cards.mdx: line 12 "Summary" bullet is two fragments — combine or split. Confirm the Pass-8 inferences on line 23 ("Task") and line 19 ("Data storage") match original meaning; confirm the View details UI label; reconcile thewandb-registryvs.wandb-registry-[REGISTRY-NAME]prefix on lines 41/44; confirm the[COLLECTION-TYPE]placeholder fortype_nameand link to accepted values.search_registry.mdx: lines 140–158 alias mismatch — Pass 8 changed proselatest→productionto match the code sample; confirm which value is intended. Verify the API accepts mixed timestamp precision ("2024-01-08"vs."2025-03-04 13:10:00"). Reword operator descriptions like "Performs AND logic to one or more conditions" ("to" → "on" or "against"). Add expected-value type or example for$exists(line 85). Verify the renamed link target on line 172 (/models/ref/python/experiments/artifact/) is titled "Artifact".Missing content
aliases.mdx: consider promoting the H3### Protected aliases(currently nested inside## Custom aliases) to its own H2; the "Create a protected alias" subsection has two consecutive procedures — confirm whether they're distinct workflows.configure_registry.mdx: no link or definition for "Organization or Restricted" registry visibility; "Inherited registry role" examples reference team roles without linking to team-role docs; verify no other pages still link to the old#registry-role-permissionsanchor (replaced by#role-permissions).create_collection.mdx: no troubleshooting beyond the artifact-type-mismatch Note; no cross-link to a "link an artifact to a collection" page; "Collection types" doesn't link to registry-level artifact-type configuration.delete_registry.mdx: line 14 references "collections" and "artifacts linked to the registry" without cross-links to concept pages.lineage.mdx: artifacts, runs, collections, and aliases are referenced without inline definitions or links.link_version.mdx: the intro mentions "private, project-level scope to a shared, organization-level scope" without defining organization vs. team entity until Troubleshooting; the Find your team entity "Copy the site's URL" instruction doesn't say where to paste it.organize-with-tags.mdx: no documentation of tag naming constraints (allowed characters, length, case, uniqueness scope), permissions for adding/removing tags, or interactions with automations/webhooks/lineage; consider whether SDK-based tag search across collections belongs here.registry_cards.mdx: enumerate or link to validtype_namevalues; replace the "Deserialize the model" bullet on line 24 with a clearer noun phrase (needs SME input).search_registry.mdx: the "similar, but not identical, to MongoDB queries" callout doesn't specify where syntax differs; the permissions note doesn't link to a permissions explainer; add a sentence describing whatregistries()/.collections()/.versions()calls return.Other observations
search_registry.mdx: normalize the two self-page link forms (./search_registry#…vs./models/registry/search_registry#…); verify<Frame>/<Info>/<Note>MDX components render as intended.download_use_artifact.mdx: Python keyword arguments in code samples use spaces around=(e.g.,entity = '<team_name>'), deviating from PEP 8 — left untouched per Pass 8 scope.How to review