style: apply /style-guide pass to models/track#2728
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
📚 Mintlify Preview Links📝 Changed (17 total)📄 Pages (17)
🤖 Generated automatically when Mintlify deployment succeeds |
🔗 Link Checker Results✅ All links are valid! No broken links were detected. Checked against: https://wb-21fd5541-style-guide-snippets-includes-20260604-122025.mintlify.app |
ngrayluna
left a comment
There was a problem hiding this comment.
Please split this into two PRs: Sweeps and Snippets.
Also, some of the comments I've applied to integration PR apply here. Apply those changes and re-run?
2039d60 to
4f19936
Compare
Apply recurring style rules from ngrayluna's review of the integrations PR (#2673) to the models/track set: - "preceding" -> "previous" - passive -> active voice; W&B (not `wandb`) as the actor performing actions - third person -> second person (address the reader as "you") - gloss `wandb` as the W&B Python SDK on first mention where context was missing Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR applies an automated style-guide normalization pass across the models/track documentation set, primarily updating wording, headings, and placeholders, and adding keywords metadata to improve consistency and discoverability.
Changes:
- Added
keywordsfront matter and updated page introductions for clearer scope and navigation. - Standardized voice, terminology, and placeholder formats across examples and procedures.
- Restructured several sections (headings/lists) for more consistent procedural flow.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| models/track/config.mdx | Adds keywords and refines configuration guidance and section structure. |
| models/track/create-an-experiment.mdx | Clarifies the end-to-end experiment workflow; updates headings and phrasing. |
| models/track/environment-variables.mdx | Adds keywords and rewrites environment-variable descriptions for clarity/consistency. |
| models/track/jupyter.mdx | Adds keywords and refines notebook workflows and magic/inline rendering instructions. |
| models/track/limits.mdx | Adds keywords; reorganizes performance/rate-limit guidance and definitions. |
| models/track/log.mdx | Adds keywords; refreshes logging overview language and common workflow descriptions. |
| models/track/log/customize-logging-axes.mdx | Adds keywords; updates placeholders and explanations around custom step metrics. |
| models/track/log/distributed-training.mdx | Adds keywords; refines distributed logging approaches and troubleshooting wording. |
| models/track/log/log-models.mdx | Adds keywords; rewrites model logging/retrieval narrative and placeholder usage. |
| models/track/log/log-summary.mdx | Adds keywords; updates summary-metrics guidance and the Public API retrieval example. |
| models/track/log/log-tables.mdx | Adds keywords; restructures table workflow sections and updates examples/placeholders. |
| models/track/log/media.mdx | Adds keywords; updates prerequisites and improves explanations of media logging. |
| models/track/log/plots.mdx | Adds keywords; reworks headings and adds more contextual framing around plot types. |
| models/track/log/working-with-csv.mdx | Adds keywords; expands intro and refines CSV→Table/Artifact instructions and wording. |
| models/track/project-page.mdx | Adds keywords; refines project tab descriptions and UI instructions; updates SDK snippet. |
| models/track/public-api-guide.mdx | Adds keywords; clarifies import/export narrative and reorganizes some sections. |
| models/track/reproduce_experiments.mdx | Adds keywords; rewrites steps and standardizes placeholder formatting. |
| models/track/workspaces.mdx | Adds keywords and expands intro; refines saved views/templates and API examples language. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks @ngrayluna! Status on both points:
Ready for another look when you have a sec. |
- log/log-summary.mdx: fix Public API example so it runs (add
`api = wandb.Api()`, `import pandas as pd`, `{project_name}` -> `{project}`)
- jupyter.mdx: correct `ipython.display(...)` -> `IPython.display(...)`
- public-api-guide.mdx: remove broken `#overview-tab` anchor link; refer to
the Overview tab without a URL
- project-page.mdx: format the collapsed Python SDK snippet across multiple lines
- log/media.mdx: replace `{DESIRED_MAX}` with a concrete integer
- workspaces.mdx: fix title grammar ("experiments" -> "experiment")
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolve the only conflict (models/track/log/plots.mdx) by keeping the style-pass rewrite, which already subsumes #2751's tweaks: it drops "quick and easy", removes "Just", and uses W&B as the actor. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Back out the `keywords:` frontmatter that the style-guide pass added to all 18 models/track pages, per the decision to drop auto-generated keywords. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolve the config.mdx conflict from #2754: - Keep the PR's heading "Set the configuration after your run has finished" (preserves the #set-the-configuration-after-your-run-has-finished anchor that support/models/articles/can-you-group-runs-by-tags.mdx links to) plus the PR's rewritten paragraph. - Retain #2754's new "View config values in the W&B App" section (auto-merged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolve the reproduce_experiments.mdx conflict by taking main's version. #2314 restructured the page and documented the new "Reproduce this run" button feature; that content supersedes the PR's style pass on the old structure. Taking the PR's version would drop the new feature (a content regression), so the PR's style edits to this one file are dropped instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
DocEngine orphan report: none — every file under the owned subtree ( |
Summary
This PR applies the
/style-guideskill (Google Developer Style Guide + CoreWeave conventions) to themodels/trackdocumentation set, normalizing voice, terminology, placeholders, and procedural patterns across 18 files. The run was fully automated; edits are style-only and require human technical review before merge.Files edited
models/track/config.mdxmodels/track/create-an-experiment.mdxmodels/track/environment-variables.mdxmodels/track/jupyter.mdxmodels/track/limits.mdxmodels/track/log.mdxmodels/track/log/customize-logging-axes.mdxmodels/track/log/distributed-training.mdxmodels/track/log/log-models.mdxmodels/track/log/log-summary.mdxmodels/track/log/log-tables.mdxmodels/track/log/media.mdxmodels/track/log/plots.mdxmodels/track/log/working-with-csv.mdxmodels/track/project-page.mdxmodels/track/public-api-guide.mdxmodels/track/reproduce_experiments.mdxmodels/track/workspaces.mdxRecommendations for technical review
Prerequisites
wandb, authenticated session, active project/entity, Python/Jupyter environment, required third-party packages) onconfig.mdx,create-an-experiment.mdx,jupyter.mdx,log-models.mdx,log-tables.mdx,plots.mdx,working-with-csv.mdx, andreproduce_experiments.mdx.jupyter.mdx:wandb.login()is shown without context about credentials or where to obtain an API key outside Colab.limits.mdx: "Performance" is never defined from a user perspective (page load vs. SDK overhead vs. training-loop latency); consider a symptoms→causes mapping in the intro.plots.mdx: The Bokeh example importshello.wavwithout describing or linking it; note that readers must supply their own audio file.project-page.mdx: "Create a project" and "Add notes to a project" don't mention account, team membership, or role requirements.workspaces.mdx: The page is titled "View experiments results" but is entirely about workspaces; reconcile title vs. scope.Verification steps
config.mdx(config saved in Run Overview),create-an-experiment.mdx(artifact location in W&B App),jupyter.mdx(after%%wandb,wandb docker --jupyter),limits.mdx(after workspace reset to manual mode),log-models.mdx(use_modeldirectory verification),log-summary.mdx(afterdefine_metricandrun.summary.update()),log-tables.mdx(table-in-workspace andget()confirmation),plots.mdx(chart appearance per type),working-with-csv.mdx(dashboard URL/click path),project-page.mdx(create/delete/star confirmations),reproduce_experiments.mdx(reproduced-run comparison), andworkspaces.mdx(save/update template confirmation; clarify the "no details" case under "View your workspace template").jupyter.mdx: Briefly explain the difference between%%wandb(cell magic) and%wandb(line magic).limits.mdx: Throughput-examples tables lack interpretation; confirm the video-table last row (500 MB at 0.07/min = 35 MB/min) is intentional given the 40 MB/min target other rows aim for.Technical accuracy
config.mdx:parser.add_argument("-lr", "--learning_rate", type=int, default=0.001, ...)usestype=intwith a0.001default — likely should betype=float.grafana_urlis set to a Markdown-link string; confirm the W&B App's References section actually renders Markdown links in config values.wandb.init()"starts a background process that syncs and logs your data as a run" (line 32), flattening of nested config dictionaries via dot notation (line 54), and auto-loading ofconfig-defaults.yamlfrom the script directory (line 231).environment-variables.mdx:WANDB_DISABLE_GIT(line 48): confirm both latest commit and diff are always captured.WANDB_RUN_ID(line 64): verifywandb(not the user) performs the non-word-character → dash conversion.WANDB_QUIETvs.WANDB_SILENT(lines 65–66): clarify the precise behavioral difference.WANDB_RESUME(line 62): verify semantics ofallowand whetherWANDB_RUN_IDis required only forallowor alsomust.WANDB_DATA_DIR(line 45): confirm "staging artifacts" wording and thatplatformdirs.user_data_diris still the default source.WANDB_ARTIFACT_DIR,WANDB_DIR,WANDB_CACHE_DIR, andWANDB_CONFIG_DIRmatch current SDK behavior.WANDB_DOCKER(line 50): verifywandb docker [IMAGE_NAME]:[TAG] --digestis still the current CLI syntax.wandbas subject — confirm the SDK/library is the actor in each case.jupyter.mdx:wandb.Run.finish()andrun.finish().%%wandbbehavior when a cell runs multiple times (line 41).ipython.display(...)vs. thedisplaysymbol imported on line 76 — verify the inline reference matchesIPython.display.display.run.finish()directly.wandb docker --jupyterstill exists and behaves as described.https://wandb.me/jupyter-interact-colabstill resolves.wandb.init()examples should migrate to the context-manager pattern recommended by the W&B section of the style guide.limits.mdx:RateLimit-Limit/RateLimit-Remainingare scaled 0–1,000.wandb sync [RUN-FILE-PATH]accepts a file path (not a directory).https://wandb.me/log-hf-colabis live.log.mdx:wandb.me/code-save-colabis still canonical for the general Code Saving setting, and confirm the in-product label casing.requirements.txtto the run's Files tab.wandb.run.summary["best_accuracy"](lowercaserun) vs.wandb.Run.log()(uppercaseRun) elsewhere — confirm and apply consistently.wandb.Run.watch(model)to its reference.log/customize-logging-axes.mdx:custom_step : intandmetric_name : intuse theintclass as a value placeholder — semantically misleading. Consider realistic integers (i,i+1) or bracket-style placeholders.i**2).run.define_metric("train/*", step_metric="train/step")— confirm this is the documented signature and clarify that the first argument is the metric name / glob pattern.log/log-models.mdx:ColabLinkURL points to a branch-specific notebook (ken-add-new-model-reg-api). Verify this is stable and not a development fork.wandb.Run.use_model()vs. body uses ofuse_modelandrun.use_model()— confirm canonical form.model.h5; verify HDF5 is still recommended over.keras.run.use_model(...)/run.log_model(...)are canonical vs. module-levelwandb.log_model(...).name = f"…"uses non-PEP 8 spacing around=for a keyword arg.#amazon-s3--gcs--azure-blob-storage-referencesstill matches the target heading intrack-external-files.log/log-summary.mdx:apireferenced withoutapi = wandb.Api(); loop usesproject_namebut the defined variable isproject;pd.DataFramecalled although the import isimport pandas(notas pd).summaryargument vs.define_metric.log/log-tables.mdx:with wandb.init() as run:block inside anotherwandb.init()context — almost certainly a bug.run-[RUN-ID]-[TABLE-NAME]:[TAG]reflects the actual run-scoped artifact naming convention.log/plots.mdx:wandb.plot_table(...)while other examples usewandb.plot.<chart>(...)— confirm both spellings are current.vega_spec_name="carey/new_chart"references a user-specific preset; replace with a placeholder or note it must be replaced.fig = plt.figure()separately" guidance for the empty-plot error is still current.log/working-with-csv.mdx:wandb.init()withblock but the snippet is truncated mid-block (as run:with no body); confirm the partial snippet reads clearly.import wandbandimport pandas as pd— verify intent.wandb.Artifact("iris_artifact", type="dataset")is unscoped; confirm docs recommend fully-qualified artifact names.project-page.mdx:"zoo-wyhak4p0"still matches the current screenshot.reproduce_experiments.mdx:<Tabs>block resets MDX numbering — visual check before merge.[COMMIT-SHA]placeholder previously hinted visually at a Git SHA via 40 characters; confirm the bracketed token is sufficient.workspaces.mdx:[ENTITY-NAME]/[WORKSPACE-URL]; confirm engineering expects bracket-style placeholders in copy/paste samples.Missing content
config.mdx: "below the root" terminology for nested config keys may be unclear; no documentation of precedence/merge behavior acrossrun.config.update(), direct assignment, YAML, and argparse; no callout on which keys can be pinned, character limits, or plain-text vs. Markdown rendering; consider marking or relinking the TF v1 flags section as legacy.create-an-experiment.mdx: image at line 120 usesalt="Quickstart Sweeps Dashboard example"with a Sweeps-specific path on an Experiments page; the<Note>at lines 41–43 may not warrant a notice; confirm "Configure Experiments" / "Log Data During Experiments" link text matches actual page titles; line 85 uses "Learn more about..." instead of the standard "For more information, see..." pattern; decide whether "Run" should be a proper noun.environment-variables.mdx: Singularity section (line 75) lacks a concreteSINGULARITYENV_example; "Run on AWS" (line 79) ends abruptly after the AWS batch link; the Singularity link points to the older LBL project, notapptainer.org/sylabs.io; the heading anchor change#running-on-aws→#run-on-awsis referenced by old slugs inko/,ja/, andfr/translations.jupyter.mdx: the bottom<Note>is used for cross-references and could be a "Next steps" / "Related" section; no guidance on ending a session cleanly or kernel restarts mid-run; bracket placeholders ([USERNAME],[PROJECT], etc.) lack a lead-in; code-fence languagenotebookis not in the CoreWeave standard set (bash,python,yaml,json,text); two long sentences (~36 and ~41 words) could be split.limits.mdx: a commented-out "Metric naming constraints" link is hidden in MDX comments; "Value size" mentionswandb.Mediatypes are "handled differently" without a link; "Metric logging API rate limits" mentions paid vs. free plans without specifying values; three near-identical Multi-tenant Cloud warnings could be consolidated; "Browser considerations" calls out Chrome only; several concepts (Artifacts, offline syncing, public API, GraphQL) lack inline definitions / outbound links; the "Many metrics per run" procedural sentence could be promoted to a bulleted step.log.mdx: title/description vs. body scope mismatch — workflows may belong on subpages; stale commented-out blocks at lines 20–25, 27, and 33–39 referencestep=andcommit=False; document or removecommit=Falsereferences; add a pointer for non-consecutive / out-of-order logging since the doc only states you can't write to a specific history step; consider splitting the 36-word "Compare the best accuracy" sentence; "Best practices and tips" is a single external link to a W&B report.log/customize-logging-axes.mdx: the Globs section (line 76+) is a substantive topic without its own H2; line 97 contains a commented-out Colab link — either restore or remove; alt text (lines 26, 73) contains literal backticks; code comment (line 88) usesw/; inconsistent kwarg spacing (step_metric = custom_stepvs.step_metric="train/step").log/log-models.mdx: no guidance on accepted file types or directory structures forlog_model; no mention of size limits or large-model considerations; no description of howlog_modelinteracts with remote reference URIs (s3://, etc.); no explanation of versioning behavior or auto-generated aliases on repeated calls; no coverage ofuse_modelerror behavior when the artifact doesn't exist; no cross-link to the "link a model to the registry" workflow;:latestalias syntax is used without explanation.log/log-summary.mdx: the list of validsummaryvalues ("min","max","mean","best","last","none") lacks one-line definitions, especially distinguishing"best"(requiresobjective) from"last"(default); the "Run Table" tab procedure (~lines 89–93) doesn't note how to add a summary column that isn't shown by default.log/log-tables.mdx:ArtifactEntrytype is referenced in the JoinedTable args table without definition or link; "Visualize tables" is a single sentence; the 200,000-row override Note could be more specific about which sizes / UI operations cause issues.log/plots.mdx:wandb.plot.line_seriesxs/ys"must match exactly" doesn't clarify shared-x vs. per-line-x auto-detection; confusion-matrix bullet says "either probabilities or predictions but not both," but onlypredsis shown — consider aprobsexample; no cross-link to a quickstart establishingwandb.initbasics.log/working-with-csv.mdx: no explanation of the 200,000-row artifact limit referenced in code comments;define_metricis mentioned but the example usesrun.summary.update()— clarify or remove; link text[Sweeps Hyperparameter Tuning](/models/sweeps/)doesn't match the canonical "Sweeps"; commented-out{% embed %}blocks at lines 11 and 97–99 — remove or restore; inconsistent comment capitalization, an ellipsis, an exclamation, and200000without a thousands separator.project-page.mdx: the line ~329 Python sample is collapsed onto a single line — reformat across multiple lines and separate theimport; placeholder URLs in the Star-a-project tabs mix<team>/<project-name>/<project_name>instead of the CoreWeave-preferred[PLACEHOLDER-NAME]; the Sweeps tab is a single sentence with only a screenshot; Project roles section doesn't enumerate roles or link to a reference; the Workspace tab section doesn't introduce the "Add panels" control referenced later; verify the "Confirm that your project is available." paragraph belongs under Create a project (currently stranded around line 367 pre-edit).reproduce_experiments.mdx: step 7 ("Optional: Create a Python virtual environment.") provides no command or link; step 1's "Name of the run you want to reproduce" prerequisite is never used explicitly in the procedure (only via branch name in the GitHub tab's step 4).workspaces.mdx: line 176 Colab URL contains a typo in the branch name (Update-wandb-workspaces-tuturial); lines 192–205 contain a large JSX-commented block duplicating the active bullet list above it — decide whether to delete; line 244 references "workspace API examples" without API reference detail; line 234 headingCopy a workspace \saved view` to another workspace` uses inline code for a concept (and changing it would break the anchor).How to review