chore(weave): in-memory trace server monitor-query validation and missing-ref reporting#7337
Merged
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
HiveMind Sessions3 sessions · 18m · $3.49
View all sessions in HiveMind → Run |
…ing-ref reporting Mirror two ClickHouse behaviors the fake backend was missing: - obj_create now calls validate_monitor_query_fields(...) so a saved Monitor with a bad query field fails loudly at create time (InvalidFieldError with the allowed-field list; structurally-invalid queries -> InvalidRequest; opaque/absent queries untouched), matching clickhouse_trace_server_batched. - refs_read_batch now collects every missing base-object digest and raises RefObjectsNotFoundError(msg, missing_object_digests) instead of failing on the first missing ref. Soft-deleted objects are 'found' (read back as None), not missing.
Un-gate the FAKE_NOT_IMPLEMENTED tests now that the fake backend covers them: monitor query validation, refs_read_batch missing-ref digests, agent user feedback, call filtering by ref-properties over table rows, and declarative evaluation child-call metadata tagging (the last three already worked on the fake; the gates were over-conservative). Re-tag two inherently CH/served-backend tests to NOT_CLICKHOUSE_BACKEND (permanent) rather than FAKE_NOT_IMPLEMENTED: test_lock_acquire_release_real_clickhouse (real ClickHouse lock) and test_flask_server (werkzeug request threads cannot reach the in-process fake client).
andrewtruong
force-pushed
the
andrew/fake-ts-10-remaining-caps
branch
from
0b1485e to
bbd8031
Compare
andrewtruong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds monitor query validation and missing-ref reporting to the fake impl, and un-gates the remaining fake-backend tests now that the fake is at parity. Last PR in the fake trace server stack.