feat(weave_ts): Add gen_ai.conversation.id as attribute on all spans in @openai/agents integration#7339
Merged
drtangible merged 1 commit intoJun 23, 2026
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
drtangible
force-pushed
the
06-22-chore_weave_ts_consolidate_trace_state_in_otel_processor
branch
2 times, most recently
from
8f233df to
5a0ac8d
Compare
This was referenced Jun 22, 2026
Merged
drtangible
changed the title
gen_ai.converstaion.id as attribute on all spans in @openai/agents integration
drtangible
changed the title
gen_ai.converstaion.id as attribute on all spans in @openai/agents integrationgen_ai.conversation.id as attribute on all spans in @openai/agents integration
…in @openai/agents integration
drtangible
force-pushed
the
06-22-chore_weave_ts_consolidate_trace_state_in_otel_processor
branch
from
5a0ac8d to
3bd20c9
Compare
andrewtruong
approved these changes
Jun 23, 2026
| this.conversationIdsByTraceId.get(span.traceId) ?? ''; | ||
| const attrs = attrsForSpan(span, conversationId); | ||
| otelSpan.setAttributes(attrs); | ||
| otelSpan.setAttributes({ |
Contributor
There was a problem hiding this comment.
Why not use BaggageSpanProcessor? and then setAttributes?
drtangible
deleted the
06-22-chore_weave_ts_consolidate_trace_state_in_otel_processor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently require this attribute on all children spans in order for certain pieces of data to populate in the Weave UI.
This change starts including
gen_ai.conversation.idas attrs on all span types, instead of only a select few.We'll have similar changes for
gen_ai.agent.nameas well as our customintegration.fooattrs further up this stack.As part of this, refactors the per-trace information we're storing, consolidating two separate
Maps into one.