mockService now creates sinon stub instead of spy#31
Open
TueCN wants to merge 4 commits intowardbell:masterfrom
Open
mockService now creates sinon stub instead of spy#31TueCN wants to merge 4 commits intowardbell:masterfrom
TueCN wants to merge 4 commits intowardbell:masterfrom
Conversation
…en the value of a config obj property is a non-function value. This makes it possible to dynamically configure the stub while testing
… try/catch so mocha can be informed about the error in a nice way that doesn't halt the test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each property value of the config obj that is a non-function value can be created as a sinon stub. This makes it possible to dynamically configure the stub further while testing, to e.g. make conditional returns based on argument values (see http://sinonjs.org/docs/#stubs-api).