Open
Conversation
Author
|
One note. This is just an exploratory PR to prove feasibility. I haven't considered all branches through |
Owner
|
Hi Chris. As I state in issue #45, I can't keep up any more. I spoke to John Papa and he thinks you'd be a motivated and capable successor. It's yours if you're willing to take it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @wardbell and contributors. I love how Bard allows injected services to be promoted to globals and makes the test relatively free from noise boilerplate instrumentation. But when I got around to adding tests for a provider I got a bit bummed that I had to add some boilerplate back in:
So I wanted to see if it would be technically possible to allow:
And was satisfied that this modified code performs as expected and demonstrates it's technically possible. However, much like John Hammond, I was so preoccupied with whether or not I could, I didn’t stop to think if I should.
Do you think this adds value? Does this violate some type of parity goal with standard
angular.mock.moduleorinject? Thoughts?