Add git read-tree completions - #296
Conversation
Co-Authored-By: Warp <agent@warp.dev>
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.
Powered by Oz
|
Addressed the same-repository issue requirement: I created #297 and updated this PR to link it with Issue #297 is now undergoing Oz triage and awaiting the maintainer-applied |
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a git read-tree command signature with options and a variadic tree-ish argument generator.
Concerns
- The option list does not cover all valid documented
git read-treeforms:--recurse-submodulesis missing its optional=<checkout>value, and--exclude-per-directory <gitignore>is omitted entirely. - No security concerns found in this JSON-only command-signature change.
- No approved spec context was provided for additional implementation-vs-spec validation.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| } | ||
| }, | ||
| { | ||
| "name": "--recurse-submodules", |
There was a problem hiding this comment.
git read-tree accepts --recurse-submodules[=<checkout>]; add an optional argument for the =<checkout> form so valid submodule-control completions are not omitted.
| ], | ||
| "description": "Suppress feedback messages" | ||
| } | ||
| ], |
There was a problem hiding this comment.
--exclude-per-directory <gitignore> option is missing from this options array, so the new signature does not cover the available read-tree flags.
Summary
git read-tree.Linked issues
Closes #297
Upstream request: warpdotdev/warp#12321
Testing
./script/presubmitcargo test -p warp-command-signatures --lib(66/66)git diff --checkgit read-tree <Tab>in a local Warp build using this checkout.Screenshot