non-multi-arch images now fail with clear error#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up for this: https://warpdev.slack.com/archives/C0AC81SR0L9/p1771440212411899?thread_ts=1771437585.553369&cid=C0AC81SR0L9
The problem was that the image appeared to pull successfully but then failed with "image not found" immediately after.
The problem was actually we were missing an ARM build on the
warpdotdev/dev-java:21image and they were using an ARM worker. We do require image to have the same platform as the host in order to avoid virtualization overhead, but that requirement is unclear here.This PR adds an explicit check and fails with a clearer error message in this case.
Note that I didn't catch this case during dogfooding b/c I only tested images with multi-arch images with modern manifest lists. For those images, we already get an error about that.
However, older non-multi-arch images will actually successfully pull even if you explictly request a different platform, see here: docker/for-mac#5625 (comment)
I tested this by creating a legacy non-multi-arch image, e.g.
I created an environment with that image...
...and tried running it with my MacBook as a self-hosted runner and I got the error I expected