fix: restore oz review invocation cap#436
Conversation
Restore the 3-per-PR cap for explicit /oz-review requests in the webhook dispatch path. Count persisted non-bot explicit review invocations across PR conversation and inline review comments before building review context, while failing open on lookup errors. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR restores explicit review invocation throttling in webhook dispatch and updates routing/tests for /oz-review and @oz-agent /review.
Concerns
- The command regex still matches hyphenated prefixes such as
/oz-review-this, so non-command text can trigger review runs and count against the cap.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
|
@peicodes @vkodithala Requesting your review on this. I observed in a PR that a user was able to keep going past the 3 /oz-review invocation limit and triggered the review agent about a dozen times on the same PR. Turns out the code to rate-limit didn't come over when I rewrote everything last week so bringing it back here. |
|
I'm re-reviewing this pull request in response to a review request. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR restores explicit review invocation throttling in the webhook dispatch path, tightens review command detection, and adds coverage for the cap across PR conversation and inline review comments.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
2 participants
Summary
/oz-reviewand@oz-agent /reviewrequests in the webhook dispatch path.Validation
python3 -m unittest tests.test_routing tests.test_builders tests.test_webhook_dispatchpython3 -m py_compile core/routing.py core/workflows/__init__.py tests/test_routing.py tests/test_builders.pygit --no-pager diff --checkArtifacts
Co-Authored-By: Oz oz-agent@warp.dev