[common-skills migration] Add repo-specific companion skills for create-pr, fix-errors, diagnose-ci-failures - #13086
[common-skills migration] Add repo-specific companion skills for create-pr, fix-errors, diagnose-ci-failures#13086vkodithala wants to merge 4 commits into
Conversation
…ailures Add three per-repo companion skills under .agents/skills/ that specialize the generic common-skills cores with Warp client toolchain specifics (presubmit/cargo/clippy, WASM + local_fs gating, View layout tests, changelog markers, integration-test rules, and CI check names). Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds three Warp repo-local companion skills for create-pr, fix-errors, and diagnose-ci-failures. The overall split makes sense, but several commands and CI mappings in the new guidance do not match the repository's current scripts/workflows, so agents following these skills can run the wrong checks or miss the actual failing CI job.
Concerns
.agents/skills/create-pr-local/SKILL.mddocuments a clippy command as matching./script/presubmit, but the script currently excludeswarp_completer, omits--all-features, and runs a separate completer clippy command..agents/skills/fix-errors-local/SKILL.mdtells agents to use rawcargo fmt -- --checkinstead of the repo's./script/format --check, which applies repository-specific rustfmt configuration.- The WASM clippy reproduction guidance omits the warnings-as-errors flags used by CI, and the CI companion lists a stale
WASM buildcheck instead of the current WASM-related check names.
Verdict
Found: 0 critical, 4 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Update create-pr-local to point at the warp-skills agent-attribution skill (warpdotdev/warp-skills:.agents/skills/agent-attribution) as the canonical source for the Oz co-author trailer and reply prefix, while keeping the trailer inline for convenience. Co-Authored-By: Oz <oz-agent@warp.dev>
vkodithala
changed the title
vkodithala
changed the title
Correct the repo-specific companions so their guidance matches the Warp client source of truth: - create-pr-local: use ./script/format --check; replace the clippy command with the presubmit-accurate pair (workspace excluding warp_completer, plus a dedicated warp_completer run); drop --all-features. - fix-errors-local: use ./script/format --check (RUSTC_BOOTSTRAP + import grouping); WASM clippy now uses --locked ... -- -D warnings. - diagnose-ci-failures-local: replace "WASM build" with the real CI job names (Formatting + Clippy (wasm), Verify compilation with release flags (wasm)) and fix the reproduction commands. Co-Authored-By: Oz <oz-agent@warp.dev>
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Generally looks good! Left one comment about how this skill might interact with the non-local companion skill being in a global directory instead of checked out at the repo.
|
|
||
| ## Prerequisite: install the parent skill | ||
|
|
||
| This skill specializes the core `create-pr` skill (named in the `specializes` frontmatter field) and is not functional on its own. Before applying its guidance, confirm the parent skill is installed and resolvable at `.agents/skills/create-pr/SKILL.md`. If it is missing, install it first by copying the skill directory from the source declared in the `specializes_source` frontmatter field (`warpdotdev/common-skills:.agents/skills/create-pr`). Then continue with the guidance below. |
There was a problem hiding this comment.
Will the directory lookup that we are using here work if the create-pr skill is located globally instead of in the current repo?
There was a problem hiding this comment.
This is a good call; directory lookup would not work if it was globally installed. Updated skill guidance in latest.
Document that parent common-skills cores can resolve by name from either the project-local or global skills directory. Co-Authored-By: Oz <oz-agent@warp.dev>
2 participants
Description
Adds three per-repo
*-localcompanion skills under.agents/skills/that specialize the corresponding generic cores inwarpdotdev/common-skills:create-pr-local(specializescreate-pr) — Warp client./script/presubmit,./script/formatandcargo clippycommands, theViewlayout-test pattern, changelog markers (CHANGELOG-NEW-FEATURE/CHANGELOG-IMPROVEMENT/CHANGELOG-BUG-FIX/CHANGELOG-IMAGE),crates/integration/P0 integration-test rules, and pointers to thewarp-integration-testandadd-feature-flagskills.fix-errors-local(specializesfix-errors) — Warp client./script/format, cargo/clippy commands, WASM (wasm32-unknown-unknown,release-wasm-debug_assertions) andlocal_fsgating,crates/warpui/app/srcpaths,./script/presubmit, andcargo nextestcommands.diagnose-ci-failures-local(specializesdiagnose-ci-failures) — Warp client CI check names (Formatting + Clippy (MacOS),Run MacOS/Linux/Windows tests,Formatting + Clippy (wasm),Verify compilation with release flags (wasm),Check CI results) and cargo-specific error categories.Each companion mirrors the existing
review-pr-localtemplate: YAML frontmatter withspecializes/specializes_source, a "Prerequisite: install the parent skill" section, and only repo/toolchain-specific guidance layered on top of the generic core. Specifics derived from this repo'sAGENTS.mdand existing skills (warp-integration-test,rust-unit-tests,add-feature-flag), and verified againstscript/presubmit,script/format, and.github/workflows/ci.yml.Motivation
This is the second PR in a series of changes intended to make common-skills plug-and-play with any repo (which should be particularly helpful for enterprises we're working with, like Narwhal) and present a public-facing library of skills curated by Warp. The end-goal here is to make our common skills library akin to something like this, rather than a set of skills specific to our client/server. Here's some more context on the motivation behind this change: https://warpdev.slack.com/archives/C08KTPNQN65/p1781557027648009.
Related PRs:
Scope
Skill content only. Does not touch
skills-lock.json,script/bootstrap,script/run,script/resolve_common_skills, or any installation/adoption/CI machinery (separate later phase).Conversation: https://staging.warp.dev/conversation/0dfca29d-85b8-4ad3-913d-e518d5ea353e
Run: https://oz.staging.warp.dev/runs/019f043f-2c36-7acf-b0fd-26c2494688fd
This PR was generated with Oz.