Skip to content

feat: add yc command completions - #14722

Closed
oz-for-oss[bot] wants to merge 1 commit into
masterfrom
oz-agent/implement-issue-5781
Closed

feat: add yc command completions#14722
oz-for-oss[bot] wants to merge 1 commit into
masterfrom
oz-agent/implement-issue-5781

Conversation

@oz-for-oss

@oz-for-oss oz-for-oss Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Closes #5781

Summary

  • Add a local yc command signature to Warp's legacy completion registry.
  • Use yc __completeNoDesc to ask the installed Yandex Cloud CLI for nested completions.
  • Provide static root command groups and common global flags for initial suggestions.
  • Cover the new behavior with focused warp_completer tests.

Validation

  • ./script/format
  • CARGO_HOME=/workspace/.cargo cargo test -p warp_completer --features test-util test_yc -- --nocapture
  • CARGO_HOME=/workspace/.cargo cargo clippy -p warp_completer --all-targets --all-features --tests -- -D warnings
  • Attempted CARGO_HOME=/workspace/.cargo cargo test -p warp_completer --features test-util -- --nocapture; unrelated existing tests fail while checking FeatureFlag::CloudEnvironments before feature flags are initialized.
  • Attempted CARGO_HOME=/workspace/.cargo cargo clippy --workspace --all-targets --all-features --tests -- -D warnings; workspace clippy fails in unrelated app/src/ai/execution_profiles/profiles_tests.rs all-features test imports/methods and existing dead-code warnings before completion.

Notes

  • Workspace-wide clippy currently stops on unrelated all-features app test issues before finishing; the changed warp_completer crate passes clippy.

Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: m1xxos <66390094+m1xxos@users.noreply.github.com>
@cla-bot cla-bot Bot added the cla-signed label Aug 5, 2026
@oz-for-oss oz-for-oss Bot mentioned this pull request Aug 5, 2026
1 task
@acarl005 acarl005 closed this Aug 6, 2026
@warp-agent-staging

Copy link
Copy Markdown
Contributor

Closing as superseded.

yc completions shipped instead in warpdotdev/command-signatures#303 (merged). Rather than a hand-written static signature in crates/warp_completer, the spec lives in the command-signatures repo as a generator that shells out to the CLI's own yc __complete, matching how other Cobra CLIs (kubectl, oc) are handled. Completions therefore track the installed yc binary and carry its descriptions, rather than being frozen in the client.

Thanks — the investigation here (particularly identifying yc's Cobra completion endpoint) fed directly into that implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add yc command Completions support

2 participants