Bump command-signatures to pick up the pkill completion spec - #14749
Merged
Conversation
warp-agent-staging
Bot
added
the
warpy-factory
`pkill <TAB>` completed filesystem paths because `pkill` had no command signature, so the argument completer fell through to `CompletionsFallbackStrategy::FilePaths` (GH #10924). command-signatures#300 adds the signature and its process-name generator, and is covered by that repo's tests. Bump the pinned rev to its merge commit. Co-Authored-By: Warp Agent <agent@warp.dev>
warp-agent-staging
Bot
force-pushed
the
factory/app-5192-bump-command-signatures-rev
branch
from
August 5, 2026 23:05
655aceb to
9b2ba15
Compare
acarl005
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependency version bump: pinned
warp-command-signaturesreva2ad4bfb…→4990fa1d4f5a9c74251c7330484a7ab6f3d38ac1.That rev is the merge commit of warpdotdev/command-signatures#300, which adds the
pkillcompletion spec and its process-name generator.pkillpreviously had no signature, so the argument completer fell through toCompletionsFallbackStrategy::FilePathsand offered filesystem paths (#10924). The bump also picks up the siblingkillallgenerator fix from the same PR.The diff is
Cargo.toml+Cargo.lockonly. TheCargo.lockchange is limited to the twowarp-command-signatures/warp-completion-metadatasource lines — a plaincargo update -padditionally re-resolved unrelatedwindows-sys/base64pins, so those two lines were applied directly instead.Linked Issue
Testing
No test is added here by request — this is a version bump, and the
pkillcompletion behavior is covered by command-signatures#300's own tests in that repo (a signature-level regression test plus generator parser tests, run under itsscript/presubmit).Checks run against the bumped rev in a Linux runner:
cargo metadata --locked— pass; the lock is consistent withCargo.tomland the new rev resolves.cargo check -p warp_completer --locked— pass; the crate that consumeswarp-command-signaturesbuilds against it.cargo fmt -p warp_completer -- --check— pass.Not run: the full workspace build/test suite, and any GUI run. CI is the backstop.
Screenshots / Videos
No visual capture — scoped out with the test at the requester's direction.
./script/runAgent Mode
CHANGELOG-BUG-FIX:
pkill <TAB>now suggests running process names instead of filesystem paths.Conversation: https://staging.warp.dev/conversation/e5efc7bf-3937-4b34-b5d4-19bf26d4890d
Run: https://oz.staging.warp.dev/runs/019fd3e8-c360-7c50-8764-c317eb92d2e5
This PR was generated with Oz.