Skip to content

Fix defects overflow#451

Open
McHaillet wants to merge 2 commits intowarpem:mainfrom
McHaillet:fix_defects_overflow
Open

Fix defects overflow#451
McHaillet wants to merge 2 commits intowarpem:mainfrom
McHaillet:fix_defects_overflow

Conversation

@McHaillet
Copy link

@McHaillet McHaillet commented Jan 16, 2026

I created a defects file (.mrc) to mask out dead pixel of the detector, but I ran into a very strange issue when trying to use it. When I run the first processing steps to get averages of my tilt movies (fs_motion_and_ctf), it seems only part of the averages have the defects correctly masked out, and it seemed completely random which ones had it correct. And, every time I rerun, the corrected files seem to randomly change without any pattern.

I had Claude go over the codebase and after some back-and-forth it managed to propose this fix... which fixed it 👍 According to Claude it a GPU memory overflow issue and it caused the observed race condition.

@dtegunov let me know if this fix makes sense to you

Summary by CodeRabbit

  • Bug Fixes
    • Corrected GPU memory transfer sizing during defect correction processing to maintain consistency with slice-based operations, improving data processing accuracy.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 48a4fd54-e793-4689-b86b-d2915b7fa622

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

@warpem warpem deleted a comment from coderabbitai bot Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant