Skip to content

redirect http to https#100

Open
RyanXiaoo wants to merge 2 commits into
waterloo-rocketry:masterfrom
RyanXiaoo:master
Open

redirect http to https#100
RyanXiaoo wants to merge 2 commits into
waterloo-rocketry:masterfrom
RyanXiaoo:master

Conversation

@RyanXiaoo
Copy link
Copy Markdown
Contributor

@RyanXiaoo RyanXiaoo commented Apr 6, 2025

Description
I added HTTPS redirection and service worker support to enable offline functionality and ensure secure connections. This includes:

HTTPS redirection script in index.html
Service worker implementation for offline caching
Service worker registration in index.jsx
This PR closes #2.

Developer Testing
Testing done:
Unable to due to localhost

Reviewer Testing


This change is Reviewable

@RyanXiaoo RyanXiaoo requested review from a team, Redstone-ray and shirleyfyx as code owners April 6, 2025 07:40
Copy link
Copy Markdown
Contributor

@Redstone-ray Redstone-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a branch of waterloorocketry:main and put your work on there, please do not merge from a forked repo.

@zangjiucheng
Copy link
Copy Markdown
Member

zangjiucheng commented Apr 6, 2025

Hello @RyanXiaoo,

Nice work on this PR. Overall, I believe the logic presented is sound.

However, there is a significant question that requires our attention: is it necessary to enforce the redirection to HTTPS (even on localhost)? This requirement could potentially hinder local development efforts, as I would need to set up an SSL certificate on my local machine and resolve the issues mentioned in the attached picture.

I am not an expert in website encrypted transfer, but since git-page automatically redirects to HTTPS, should we also implement this functionality in code? If necessary, could it provide a development mode from the environment that disables the redirect function?

image

@zangjiucheng
Copy link
Copy Markdown
Member

Please make a branch of waterloorocketry:main and put your work on there, please do not merge from a forked repo.

@Redstone-ray In my opinion, this is not a significant concern. Most open-source projects welcome contributions from external sources. We can simply add different remote URLs. Regardless, the pull request will be accepted by me.

@Redstone-ray
Copy link
Copy Markdown
Contributor

Redstone-ray commented Apr 6, 2025

Please make a branch of waterloorocketry:main and put your work on there, please do not merge from a forked repo.

@Redstone-ray In my opinion, this is not a significant concern. Most open-source projects welcome contributions from external sources. We can simply add different remote URLs. Regardless, the pull request will be accepted by me.

That was a standard passed down from past rocketry members so changes are more traceable. I'm not the first one to say it but if you are happy then I am good either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants