redirect http to https#100
Conversation
http to https
Redstone-ray
left a comment
There was a problem hiding this comment.
Please make a branch of waterloorocketry:main and put your work on there, please do not merge from a forked repo.
|
Hello @RyanXiaoo, Nice work on this PR. Overall, I believe the logic presented is sound. However, there is a significant question that requires our attention: is it necessary to enforce the redirection to HTTPS (even on localhost)? This requirement could potentially hinder local development efforts, as I would need to set up an SSL certificate on my local machine and resolve the issues mentioned in the attached picture. I am not an expert in website encrypted transfer, but since git-page automatically redirects to HTTPS, should we also implement this functionality in code? If necessary, could it provide a development mode from the environment that disables the redirect function?
|
@Redstone-ray In my opinion, this is not a significant concern. Most open-source projects welcome contributions from external sources. We can simply add different remote URLs. Regardless, the pull request will be accepted by me. |
That was a standard passed down from past rocketry members so changes are more traceable. I'm not the first one to say it but if you are happy then I am good either way |

Description
I added HTTPS redirection and service worker support to enable offline functionality and ensure secure connections. This includes:
HTTPS redirection script in index.html
Service worker implementation for offline caching
Service worker registration in index.jsx
This PR closes #2.
Developer Testing
Testing done:
Unable to due to localhost
Reviewer Testing
This change is