added 'split' pipe that was missing, and fixed broken loops #1
Merged
Conversation
…ped on like described in README example "{{names|split:;}} {{.}} {{/names}}"
see : Markup.js README ('split' pipe documentation)
mattparlane
added a commit
that referenced
this pull request
Apr 3, 2013
added 'split' pipe that was missing, and fixed broken loops
Member
|
Looks great, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the 'split' pipe was missing from the core pipes, so I added it.
I also contributed a fix for broken loops when using pipes that convert variables into arrays (I'm currently relying on this for a bunch of custom pipes and using 'split' as well in a project)
Same patch for Markup.js here : adammark/Markup.js#19